Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: conditionally focus terminal if phoenix is active #463

Closed
wants to merge 1 commit into from

Conversation

kumaryogesh17
Copy link

@kumaryogesh17 kumaryogesh17 commented Jun 7, 2024

Issue #453
Added conditional statement that checks whether the variable phoenix exists and whether the phoenix application is active. If both conditions are met, it sets focus to the terminal window.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jelveh
Copy link
Contributor

jelveh commented Jun 7, 2024

Thank you for the PR. Could look into the CLA before I can review/merge this.

@KernelDeimos
Copy link
Contributor

What is this for? If this is suppressing an error we should determine the root cause instead.

@jelveh
Copy link
Contributor

jelveh commented Jul 7, 2024

I'm closing this due to no response

@jelveh jelveh closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants