Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "<", ">" from default uninstallReason #137

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

MRawlings
Copy link
Contributor

Remove "<", ">" from default uninstallReason

The OpsRamp API actively rejects an uninstallReason that contains the characters "<", or ">". Remove those character to make the default operation valid.

Both forms have been verified using Postman:

  • "<Not specified>" - is rejected

  • "Not specified" - is accepted

  • Fix associated unit test.

Drive-by:

  • add another comma to make 'black' happy

The OpsRamp API actively rejects an `uninstallReason` that contains the characters "<", or ">".
Remove those character to make the default operation valid.

Both forms have been verified using Postman:
- `"<Not specified>"` - is rejected
- `"Not specified"` - is accepted

- Fix associated unit test.

Drive-by:
- add another comma to make 'black' happy
Copy link
Contributor

@jofegan jofegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jofegan jofegan merged commit c36b7fc into HewlettPackard:master Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants