Cmf integrations with external frameworks [need feedback and review] #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mechanism is based on `callbacks`. The Cmf init method accepts the list of callback instances that users can provide. Several callbacks include Neo4j (refactored existing implementation) and MLflow. These callbacks do not replace the core Cmf features. Instead, they allow to send Cmf data to someplace else.
Usage example:
```python
from cmflib.cmf import Cmf
from cmflib.integration.neo4j import Neo4JCallback
from cmflib.integration.mlflow import MLflowCallback
cmf = Cmf(
filename='mlmd',
pipeline_name='mnist',
callbacks=[
Neo4JCallback(),
MLflowCallback()
]
)
```
This opens up several opportunities, such as, for instance, making certain `cmflib` dependencies optional.
sergey-serebryakov
requested review from
annmary-roy,
atripathy86,
martin-foltin and
suparna-bhattacharya
Resolving conflicts (cmflib/cmf.py).
- This implementaiton is in its early stages. The goal is to collect feedback and see if such an integration useful. - Supported artifacts - execution metrics. This is only supported when there's only one named group of metrics, e.g., respective callback `on_artifact_event` is called once for `ExecutionMetrics` class instance. If multiple metric groups exist, Determined will raise an exception - it requires epochs to be presented in strickly increasing order.
sergey-serebryakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mechanism is based on
callbacks. The Cmf init method accepts the list of callback instances that users can provide. Several callbacks include Neo4j (refactored existing implementation) and MLflow. These callbacks do not replace the core Cmf features. Instead, they allow to send Cmf data to someplace else.Usage example:
This opens up several opportunities, such as, for instance, making certain
cmflibdependencies optional.