Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmf and dvc integration #170

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

rishabhsharma22
Copy link
Collaborator

Related Issues / Pull Requests

List all related issues and/or pull requests if there are any.

Description

Include a brief summary of the proposed changes.

What changes are proposed in this pull request?

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected; for instance,
    examples in this repository need to be updated too).
  • This change requires a documentation update.

Checklist:

  • My code follows the style guidelines of this project (PEP-8 with Google-style docstrings).
  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings that
    uses Google-style formatting and any other formatting that is supported by mkdocs and plugins this project
    uses.
  • I have commented my code.
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

self.mode = mode
if tags:
prefix = 'Training_Metrics_' + str(os.environ['stage_name'])+'_'+str(os.environ['execution_name'])
prefixed = [filename for filename in os.listdir('.') if filename.startswith(prefix)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets sync up on what you are doing here

def log(self, runner):
tags = self.get_loggable_tags(runner)
mode = self.get_mode(runner)
print(mode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed ?

self.cmf_logger = cmf.Cmf(filename="mlmd", pipeline_name=self.exp_name , graph=True)
self.context = self.cmf_logger.create_context(os.environ['stage_name'])

file_ = os.path.isfile(self.mlmdFilePath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere else ? can this be cleaned up ?

@@ -0,0 +1,68 @@
# Copyright (c) OpenMMLab. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed ?

@annmary-roy annmary-roy merged commit b90cf34 into al_objectdetection May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants