Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary module identifiers support #291

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Sep 11, 2024

TypeScript 5.6 supported arbitrary module identifiers.

declare const some_imports: unknown;
export { some_imports as "some imports" };

import { "some imports" as foo } from "./module.js";

Syntax highlighting for the export statement worked fine out-of-box but import statement didn't work (notice the string literal is not highlighted):

image

This PR fixes the syntax highlighting with renaming typescriptTypeBlock to typescriptImportBlock. The screenshot after the fix is:

image

I also updated the files in merged/*.vim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant