-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render SelectFields as MUI Selects #4059
Draft
CommandMC
wants to merge
13
commits into
main
Choose a base branch
from
feat/web-dropdowns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renders most drop-down selection prompts inside Heroic. In turn, these dropdowns now work inside the Gamescope session. Current issues: - Controller navigation does not work, hitting "Down" opens the dropdown, with no way to navigate further down to other components - There is a black box in the top-left of the component, where the label should be
MUI CSS class names are not stable, they cannot be used like this
I prefer to use this over CSS rules in a separate file since it can sometimes be unclear where "the magic happens". Having layout and style together is clearer IMO
This will definitely break things, but it makes selects work
CommandMC
force-pushed
the
feat/web-dropdowns
branch
from
November 24, 2024 23:58
253e014
to
7746476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renders most drop-down selection prompts inside Heroic. In turn, these dropdowns now work inside the Gamescope session.
Current issues:
Use the following Checklist if you have changed something on the Backend or Frontend: