-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] some issues with sideloads #3767
base: main
Are you sure you want to change the base?
Conversation
I'm trying to reproduce what you mention of the |
e11a75a
to
eda1cf3
Compare
@@ -187,6 +187,11 @@ export async function launchGame( | |||
return false | |||
} | |||
|
|||
appendGamePlayLog( | |||
gameInfo, | |||
`Launch Command: ${executable} ${launcherArgs ?? ''}\n` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue I noticed with this is that it doesn't really print the launch command, it prints the executable and arguments only. So for a native game this is fine, but for a game using wine/proton this doesn't really show the actual command? for the different stores we print more data also like env variables for example
fixes sideload logs (end of log was printed early)Use the following Checklist if you have changed something on the Backend or Frontend: