Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] some issues with sideloads #3767

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented May 18, 2024

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 28, 2024
@arielj
Copy link
Collaborator

arielj commented Jun 1, 2024

I'm trying to reproduce what you mention of the End of log printed early but I can't reproduce that, I tried 3 sideloaded games and that always happens at the end

src/backend/launcher.ts Outdated Show resolved Hide resolved
src/backend/storeManagers/sideload/games.ts Outdated Show resolved Hide resolved
src/backend/launcher.ts Outdated Show resolved Hide resolved
src/backend/launcher.ts Outdated Show resolved Hide resolved
@@ -187,6 +187,11 @@ export async function launchGame(
return false
}

appendGamePlayLog(
gameInfo,
`Launch Command: ${executable} ${launcherArgs ?? ''}\n`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue I noticed with this is that it doesn't really print the launch command, it prints the executable and arguments only. So for a native game this is fine, but for a game using wine/proton this doesn't really show the actual command? for the different stores we print more data also like env variables for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mangohud no longer appears
3 participants