Update dependencies and support ES6#349
Merged
dignifiedquire merged 2 commits intoHenrikJoreteg:masterfrom Nov 21, 2017
hacdias:master
Merged
Update dependencies and support ES6#349dignifiedquire merged 2 commits intoHenrikJoreteg:masterfrom hacdias:master
dignifiedquire merged 2 commits intoHenrikJoreteg:masterfrom
hacdias:master
Conversation
30 tasks
daviddias
approved these changes
Nov 21, 2017
Collaborator
dignifiedquire
left a comment
dignifiedquire
left a comment
There was a problem hiding this comment.
Upgrading to webpack 3 is a breaking. As this module doesn't have good tests we need to ensure things are still working.
Can you please check that all breaking changes here don't influence the workings of this module: https://github.com/webpack/webpack/releases/tag/v3.0.0
Contributor
Author
|
@dignifiedquire for what I saw in that page, it doesn't seem that any breaking change in there would break this plugin. 😄 |
Collaborator
|
Thank you. Published as 9.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
This is a very simple PR 😄 I'm just updating the dependencies and using UglifyJS from its own package and not the version from
webpack.optimizesince it doesn't support ES6 yet.Thanks!