Type issue #1029
Merged
Type issue #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AttributeError with Icinga DB 1.2.0 / Icinga DB Web 1.1.2 HenriWahl#1028 Nagstamon Error: AttributeError: 'bool' object has no attribute 'replace'
HenriWahl
reviewed
Apr 20, 2024
| @@ -220,7 +220,8 @@ def _get_status(self): | |||
| self.new_hosts[host_name].notifications_disabled = not int(h.get('notifications_enabled') or '0') | |||
| self.new_hosts[host_name].flapping = bool(int(h['state']['is_flapping'] or 0)) | |||
| #s['state']['is_acknowledged'] can be null, 0, 1, or 'sticky' | |||
| self.new_hosts[host_name].acknowledged = bool(int(h['state']['is_acknowledged'].replace('sticky', '1') or 0)) | |||
| #self.new_hosts[host_name].acknowledged = bool(int(h['state']['is_acknowledged'].replace('sticky', '1') or 0)) | |||
| self.new_hosts[host_name].acknowledged = h['state']['is_acknowledged'] if isinstance(h['state']['is_acknowledged'], (bool)) else bool(int(h['state']['is_acknowledged'].replace('sticky', '1') or 0)) | |||
There was a problem hiding this comment.
Shouldn't it work with bool instead of (bool) too?
There was a problem hiding this comment.
works for me with the correction from @HenriWahl
HenriWahl
reviewed
Apr 20, 2024
| @@ -323,7 +324,8 @@ def _get_status(self): | |||
| self.new_hosts[host_name].services[service_name].notifications_disabled = not int(s.get('notifications_enabled') or '0') | |||
| self.new_hosts[host_name].services[service_name].flapping = bool(int(s['state']['is_flapping'] or 0)) | |||
| #s['state']['is_acknowledged'] can be null, 0, 1, or 'sticky' | |||
| self.new_hosts[host_name].services[service_name].acknowledged = bool(int(s['state']['is_acknowledged'].replace('sticky', '1') or 0)) | |||
| #self.new_hosts[host_name].services[service_name].acknowledged = bool(int(s['state']['is_acknowledged'].replace('sticky', '1') or 0)) | |||
| self.new_hosts[host_name].services[service_name].acknowledged = s['state']['is_acknowledged'] if isinstance(s['state']['is_acknowledged'], (bool)) else bool(int(s['state']['is_acknowledged'].replace('sticky', '1') or 0)) | |||
|
Please check latest release 3.15-20240503. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Attempt to fix the issue:
AttributeError with Icinga DB 1.2.0 / Icinga DB Web 1.1.2 #1028 Nagstamon Error: AttributeError: 'bool' object has no attribute 'replace'
First pull request ever so please review carefully.
Slightly modified two lines, my nagstamon works after the changes.