-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More cursor keys #933
More cursor keys #933
Conversation
Sorry for creating merge conflicts here, though they should be pretty simple to solve (you don't even need to change the codes for word left/right) |
936e255
to
da649c2
Compare
085de43
to
a92d108
Compare
after a fair bit of hot-wiring, this is ready to go 🙃 |
Not much time for review on my side though. May take up to 2 days until I can have a look. |
1757c58
to
69520ca
Compare
app/src/main/java/helium314/keyboard/keyboard/internal/keyboard_parser/floris/KeyCode.kt
Outdated
Show resolved
Hide resolved
Code looks good, with exception for the changed key codes. |
69520ca
to
8124528
Compare
f729731
to
cc74852
Compare
somehow a bunch of other stuff i was working on got merged in, so I had to force-push it out :/ About the repeat interval, I do think at most 10 per second would be best for the more drastic movers. |
No problem, there was only the keycode change to do |
This patch implements toolbar keys for the following previously-reserved codes:
It also adds a new pair: word left/right. These replace line start/end for the left/right long-clicks in the toolbar.
To test these keys, you can replace your numpad layout with this D-pad prototype: dpad_toy.json. The "double-arrow" keys are repeatable the main keyboard.
Small issue
The word-move keys are based on emulated Ctrl+Left/Right arrows. Android handles this differently from PCs:
Because I'm CooCoo bananas: I've made a rich-input implementation of "selection units" which is utilized for a word-delete slider in the upcoming more-delete-keys. That can be recycled into a non-keycode implementation of word left/right later on for non-primitive input, just as it'll be recycled for "select adjacent word" keys.
Split from #925
Progress on #357