Add caps lock indicator

[codokie]

I made some changes to the different shift states icons.
(note: the color of the theme is used in shifted/caps lock states, below I used the Brown color but in practice it can be whatever color is chosen in the theme settings)
unshifted state:
[material]

[holo] (unchanged)

shifted state:
[material]

[holo] (unchaged)

caps lock:
[material]

[holo]

Credit to Google/Material Icons for the base icons, and @Uranusek for the ideas for the icons
Rounded theme has the same icons as the material theme, only that the icons are slightly rounded
(fixes #683)

[Uranusek]

In my opinion, this icon does not fit other themes than Holo. What do you think about something like this?

no shift - regular icon
pressed shift - add accent
caps lock - add a second arrow above the current one

And for the Holo style, maybe add a line under the arrow when caps lock is pressed 🤔

[Uranusek]

Looks good. My idea was to change the icon only after pressing Caps Lock + adding an accent. Pressing Shift would only add an accent, not change the icon. I like the accent when I press the Shift key.

[Uranusek]

I understand. In Gboard, the icon changed when I pressed Caps Lock. I thought it would be easy to do the same in HeliBoard.

[Uranusek]

For now, I don't have a good idea for the third icon. Maybe add a second ^ above the current one 🤔

I think two icons would also be sufficient. Just like in Gboard. For most, I think it would be intuitive.

[BlackyHawky]

Perhaps you could use a simple arrow for Caps Lock mode while keeping the bottom bar?
In any case, the double arrow for shifted state is a good idea.

Quick question: will these icons be rounded for the Rounded style?

[Uranusek]

For Holo it's great. For the rest of the themes I would do this:

unshifted:

shifted (with accent):

caps lock (with accent):

[Uranusek]

Yes. I think two icons would be more intuitive. I'm a little confused when I see three icons when switching. Moreover, each icon has become different. In my opinion, this is unnecessary complication :/ It was enough to add an icon for caps lock and leave the rest as they were.

[Uranusek]

I think this icon might be too small and not look good.

It would be good to record what these icons look like on the keyboard. Both the current ones and those from my idea. It will be easier to decide which ones look better.

[Uranusek]

Looks nice. I wonder what the keyboard would look like with the changes I proposed 🤔

[Uranusek]

Thanks. I like my option a bit more, but both are cool.
Helium said it would be possible to customize the color of this icon in the future. Everyone will be able to choose their own, so the accent will be clearly visible.
#529

[BabyOilJohnson]

Hi, @codokie can u try my idea.
Just like the ideas of Uranusek, instead of the addition arrow replace it with another dash above the arrow.

[Helium314]

Finally some basic review:
Code changes are fine, and so is using 3 icons.

But I have to say I'm not happy with the icons, mainly I just don't like the double arrows.
My suggestion would be using the single ^ for unshifted state, and

• either the current shift icon for shifted state (but normal color), and set accent color when locked
  • I ike this more
• or the ^ icon also for shifted state (accent color), and the current icon (with accent color) when locked
  • this is more consistent with when the bar is added below the icon

(Holo looks mostly fine, but the width and position change of the arrow when locking is somewhat weird)

[Helium314]

@Helium314 thanks for the feedback! I prefer the second option you mentioned because this icon is called "Keyboard Capslock".

Using Android defaults is certainly a good reason to do it like that, thank for noticing this.

I updated the main post so you can see how it looks

Thanks, though you missed the holo shift icon (it's fine in app, I already checked)