Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined popup on the layout for bn-BD #1321

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Conversation

RHJihan
Copy link
Contributor

@RHJihan RHJihan commented Jan 24, 2025

Defined popup on the layout for a better user experience. Now, it perfectly mimics the look of a standard Bengali layout with the default configuration.
Fixes #324

@RHJihan RHJihan changed the title Defined popup on the layout Defined popup on the layout for bn-BD Jan 24, 2025
@RHJihan RHJihan marked this pull request as draft January 24, 2025 12:28
@Helium314
Copy link
Owner

What do you need the placeholder popups for? I wasn't even aware they can be added to popups.

@RHJihan
Copy link
Contributor Author

RHJihan commented Jan 26, 2025

What do you need the placeholder popups for? I wasn't even aware they can be added to popups.

According to the wiki, placeholder can be used to hide hint for a specific key.
I wanted to use placeholder to ensure that popups-hints for Bengali are only relevant to the layout. This approach mimics the standard Bengali keyboard look out of the box. Some Bengali characters are only accessible via popups. So displaying hints unrelated to Bengali characters can be distracting.

@Helium314
Copy link
Owner

This is a workaround that may break at some point. It's not intended behavior.

Better use labelFlags if you don't want hints.

@BlackyHawky
Copy link
Contributor

BlackyHawky commented Jan 26, 2025

@RHJihan
Indeed, you can write for example:

    { "label": "z", "type": "normal", "labelFlags": 1073741824, "popup": { "main": { "label": "\\" }, "relevant":
        [
            { "label": "`" },
            { "label": "undo" }
        ] }
    },

The hint will be hidden for the "z" character.

I have to update the wiki...

Edit: wiki updated.

and set autoColumnOrder for some popups
@RHJihan
Copy link
Contributor Author

RHJihan commented Jan 26, 2025

Thanks for the clarification.

@RHJihan RHJihan marked this pull request as ready for review January 27, 2025 04:40
@RHJihan
Copy link
Contributor Author

RHJihan commented Jan 27, 2025

Updated with "labelFlags": 1073741824. Now, it mostly mimics a standard Bengali keyboard look with the default settings.

@Helium314
Copy link
Owner

Alright, good to have this solved. And we have a new record holder when it comes to enormous layout files 😁

@Helium314 Helium314 merged commit 0d48a18 into Helium314:main Jan 28, 2025
@RHJihan RHJihan deleted the bn-BD branch January 29, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New parser for the bengali layout
3 participants