Lsm upgrades mynn for p8c#20
Merged
RongqianYang-NOAA merged 4 commits intoMar 24, 2022
Merged
Conversation
HelinWei-NOAA
pushed a commit
that referenced
this pull request
Nov 23, 2022
Update ci_test with ufs/dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have included the MYNN sfc scheme as 'iopt_sfc' = 4 on the top of the latest land updates (for p8c) in Noah MP. It involves 4 files: 1) the driver meta file, driver, glacier and non-glacier subroutines. The inclusion is done with 3 separate commits - 1) driver and meta; 2) the glacier changes, and 3) non-glacier changes. The initial inclusion was based on the RRFS code (from NCAR ccpp-physics - about end of January). The RRFS code does not have the new option 'opt_trs' so I can't test the new adapted code. I think it should compile ok. Let me know if you have questions. Thanks.