Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft of "use_geoms" #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

draft of "use_geoms" #3

wants to merge 2 commits into from

Conversation

vjcitn
Copy link
Collaborator

@vjcitn vjcitn commented Nov 25, 2024

This is not how I wanted to do this but anyway. I don't know if these functions are actually contributing
anything new. I need to spend more time with what you already have. Feel free to close this if it
looks redundant.

@HelenaLC
Copy link
Owner

"This is not how I wanted to do this" is referring to the package split...? I'm sorry this caused such a hassle; but hopefully smoother moving forward... and yes, the PR certainly has interesting ideas that I will incorporate either here or the main pkg. Thank you, always, for any contribution really...

@vjcitn
Copy link
Collaborator Author

vjcitn commented Nov 25, 2024

'not how i planned" was referring to the fact that i PRd directly on your repo instead of driving from my fork.
i need more github training ... happy to see the refactoring of viz material into this package, it makes sense.

@vjcitn
Copy link
Collaborator Author

vjcitn commented Nov 25, 2024

I see how to make the checks pass, will do ASAP.

@HelenaLC
Copy link
Owner

HelenaLC commented Dec 3, 2024

Fyi that I'll try to pull this locally, resolve, pass checks, and merge; ok?

@vjcitn
Copy link
Collaborator Author

vjcitn commented Dec 3, 2024

I don't think this vignette adds much. I think with better doc we can just avoid the tasks in this vignette

@HelenaLC
Copy link
Owner

HelenaLC commented Dec 3, 2024

Agree re vignette. Tho using geom_sf and adding point subsets look useful. Will ponder on how to incorporate these ideas. Currently shape rendering is a bit hacky and one would have to create a point subset in the object = not so good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants