Migrate to pcre2 #249
Merged
Migrate to pcre2 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. `new EReg("abc\x00def", "")` would erroneously match "abc"
HaxeFoundation/haxe#10592
We can no longer link pcre as we use pcre2
|
I see green CI, I merge. |
6 tasks
Merged
andyli
pushed a commit
that referenced
this pull request
Jul 4, 2023
* [regex] Update pcre to pcre2
* [regex] Throw if accessing match after match error
* [regex] Prevent null character breaking patterns
e.g. `new EReg("abc\x00def", "")` would erroneously match "abc"
HaxeFoundation/haxe#10592
* [regex] Add TODO regarding pcre2_substitute
* [cmake] Fix static Apache build
We can no longer link pcre as we use pcre2
* [cmake] Fix windows pcre static build
* [cmake] Download old PCRE for Apache
* [cmake] Remove unused flag for pcre windows build
* [cmake] Reenable PCRE_STATIC cmake flag for Win
* [cmake] Use https for pcre download for Apache
Co-authored-by: Simon Krajewski <[email protected]>
# Conflicts:
# Earthfile
# README.md
# extra/azure-pipelines/Brewfile-STATIC_DEPS_NONE
# libs/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #247
This updates the regex code to use the pcre2 library.
Behaviour should be mostly identical, apart from two intentional changes:
nullcharacter no longer breaks patterns Null character breaks regex patterns haxe#10592Would be good for someone to double check.