Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #231

Merged
merged 8 commits into from
Oct 20, 2021
Merged

Fix CI #231

merged 8 commits into from
Oct 20, 2021

Conversation

tobil4sk
Copy link
Member

@tobil4sk tobil4sk commented Aug 26, 2021 •
edited
Loading

Pull request to get CI working again.

Depends on: #225

Fix mariadb-connector-c CMake error
660fba0 
* Fix "Flow control statements are not properly nested." error from newer CMake

Signed-off-by: Daniel Llewellyn <[email protected]>
@tobil4sk tobil4sk force-pushed the fix-ci branch 3 times, most recently from bf23094 to 432de8d Compare August 26, 2021 23:38
@tobil4sk
[CI] Remove vs2015-win2012r2 and add windows-2019
ba1b465 
- Use `vs2017-win2016` for chocolatey
@tobil4sk tobil4sk force-pushed the fix-ci branch 3 times, most recently from ab9867d to c1c9310 Compare August 29, 2021 18:03
@tobil4sk
[CI] Fix Mac build
d385d6f 
Remove conflicting Python version prior to installing dependencies

Link mbedtls@2
@tobil4sk
Copy link
Member Author

I was looking through the PRs; this has changes that resolve #208 and #209.

@tobil4sk tobil4sk mentioned this pull request Oct 20, 2021
Merged
@Simn
Copy link
Member

Simn commented Oct 20, 2021

I have no idea what this does but oh well, it's neko \o/

@Simn Simn merged commit a88ed6b into HaxeFoundation:master Oct 20, 2021
@tobil4sk
Copy link
Member Author

Thanks, to summarise it just fixes some broken dependency links/versions and updates the OS builds as some had been removed from azure pipelines. As a sidenote, now that this has been merged #208, #209 and #225 are now effectively redundant (in some cases they were already out of date), so they can be closed to clean things up.

@tobil4sk tobil4sk deleted the fix-ci branch October 20, 2021 19:13
@Simn
Copy link
Member

Simn commented Oct 20, 2021

Alright, thank you! Just point me at the next PR.

@tobil4sk
Copy link
Member Author

Once #233 passes the only one left is the one to the Haxe repository itself: HaxeFoundation/haxe#10402

@Simn
Copy link
Member

Simn commented Oct 20, 2021

Nice, I'm enjoying this quest chain!

@tobil4sk
Copy link
Member Author

Seems like the deploy stage failed... The PPA job seems to be broken because it tried to use Ubuntu 16, which I'm assuming is the default if no version is specified. I think #234 should fix that failure at least?

@tobil4sk
Copy link
Member Author

Ok so that PR fixed the PPA job, however the S3 job is still failing:
https://dev.azure.com/HaxeFoundation/GitHubPublic/_build/results?buildId=8591&view=logs&j=a2b6ff8e-93b1-562c-b496-4ec6258421ad&t=72aeab33-1766-5c7a-84dd-10f11f6659dc
I'm not really sure what's going wrong here as I'm not experienced in azure pipelines. However, this would have to be fixed in order for the compiler tests to be able to access the newest version of neko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobil4sk @Simn