Keep reference to k_db abstract and avoid early finalizer call #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the SQLite CFFI library, `connect` returns an abstract Neko value, of
`k_db` kind and with a finalizer set. If the `k_result` request value
only keeps a pointer to the db struct, instead of the corresponding
`k_db` value, the finalizer will be called as soon as no other external
references remain to that connection, even if the request itself is
still reachable.
The issue could manifest in code like (Haxe):
var rs = Sqlite.open("db.db").request("select * from tbl");
trace(rs.length);
|
Should we should check if val_db(r->database) == NULL since the database might have been closed in the meanwhile |
|
@ncannasse maybe, where exactly do you mean? One thing I noticed is that |
|
I was told to merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SQLite CFFI library,
connectreturns an abstract Neko value, ofk_dbkind and with a finalizer set. If thek_resultrequest value only keeps a pointer to the db struct, instead of the correspondingk_dbvalue, the finalizer will be called as soon as no other externalreferences remain to that connection, even if the request itself is still reachable.
The issue could manifest in code like (Haxe):
Related: HaxeFoundation/haxe#8728