Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've accidentally stumbled upon one of my old branches and found it interesting :)
This is a proof-of-concept of how
trace
could be handled in a less hacky and more versatile way:Instead of hard-coding
trace
and everything about it into the typer (and`trace
as well), we provide a global static import fromhaxe.Trace.trace
, wherehaxe.Trace
is an extern class with the statictrace
method that takesRest
arguments.Then, at the filters stage we rewrite calls to it into
haxe.Log.trace
calls so it behaves the same. But the cool part is that the user can provide their ownhaxe.Trace
with their own implementation (could as well be amacro
that generates something native or just a normal rest-arg method if/when we have #9274).