Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions #9259

Merged
merged 7 commits into from
Jun 2, 2020
Merged

Github actions #9259

merged 7 commits into from
Jun 2, 2020

Conversation

RblSb
Copy link
Member

@RblSb RblSb commented Mar 21, 2020

Same CI duration without painful setup :shipit:

About fails:

Other problems:

  • Because GH Actions currently doesn't have anchors/template and job-file dependency support i use simple preprocessor script to replace @import path/file in main file.
  • I don't know how to install Neko from binary on Unix, it fails on haxelib setup. So Neko is downloaded from package managers.

Test results here: https://github.com/RblSb/haxe/actions/runs/105680989

Copy link
Member

@Aurel300 Aurel300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look at #9199 today. Can you reproduce the ssl.hdll failure locally?

extra/github-actions/Main.hx Outdated Show resolved Hide resolved
extra/github-actions/build-mac.yml Outdated Show resolved Hide resolved
extra/github-actions/install-neko.yml Outdated Show resolved Hide resolved
extra/github-actions/install-neko.yml Outdated Show resolved Hide resolved
extra/github-actions/workflows/main.yml Outdated Show resolved Hide resolved
extra/github-actions/workflows/main.yml Outdated Show resolved Hide resolved
extra/github-actions/workflows/main.yml Outdated Show resolved Hide resolved
@RblSb RblSb force-pushed the github_actions branch 2 times, most recently from 3d3a97c to f3f2cc4 Compare March 21, 2020 20:20
@RblSb
Copy link
Member Author

RblSb commented Mar 21, 2020

@Aurel300
Copy link
Member

See #9262 for a fix of the Unicode issue.

@Aurel300
Copy link
Member

Now merged, so please rebase to hopefully fix Mac. The important line for the CI is:

https://github.com/HaxeFoundation/haxe/pull/9262/files#diff-fec826feae04e51c0d94076385408bdcR178-R180

As for Lua, I guess PCRE has to be installed on its own before librex-pcre?

@jdonaldson
Copy link
Member

jdonaldson commented Mar 23, 2020

regarding pcre, I ran into this same problem. I resolved it by simply running the pcre header installation early in the RunCI class.

I haven't looked through this new build pipeline in any detail... are c libraries built after haxe related library installations for some reason? If they are, what's a good way forward? Maybe some kind of pre-build phase for targets like Lua?

@RblSb
Copy link
Member Author

RblSb commented Mar 23, 2020

@jdonaldson you mean in runci/targets/Lua? I see only pcre installation for Linux/MacOS, can you point to Windows stuff?

@jdonaldson
Copy link
Member

Sorry, not windows specifically. I was referring to early efforts at running minimalist CI builds without libpcre.

It seems like one easy way forward is to use the pcre libraries provided by hxcpp. I'm not fluent with Windows, but maybe @hughsando might have some initial tips.

@RealyUniqueName RealyUniqueName added this to the Backlog milestone Mar 30, 2020
@Simn
Copy link
Member

Simn commented Apr 26, 2020

What is the status here? I don't want the efforts already made to go to waste.

@hughsando
Copy link
Member

Hxcpp does not actually build a libpcre library, but it has everything you need to do so. So it could be something like download/install some version of hxcpp, then run hxcpp on some reasonably simple build.xml file and get a library that you could link against. It does take a little while to build this particular library (30 seconds?) - not sure how you want to integrate this.

@RblSb RblSb force-pushed the github_actions branch from f3f2cc4 to 70048e4 Compare May 2, 2020 05:00
@RblSb
Copy link
Member Author

RblSb commented May 2, 2020

https://github.com/RblSb/haxe/actions/runs/93630892
Mac sys targets still have problems, windows/linux js are failing now.
Can reproduce hl problem on mac (10.14), do not have much ideas still.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@nadako
Copy link
Member

nadako commented May 13, 2020

Let's have this! \o/

@Aurel300
Copy link
Member

I thought @RblSb still needed to address the Mac FS problem. But I see the last force push somehow had a CI pass, although it can not be inspected anymore … What happened?

@RblSb RblSb force-pushed the github_actions branch from 70048e4 to 70725af Compare May 13, 2020 23:03
@RblSb RblSb force-pushed the github_actions branch from 70725af to 0a180f8 Compare May 13, 2020 23:26
@RblSb RblSb force-pushed the github_actions branch from 4fdc495 to a344a25 Compare May 15, 2020 12:44
@Simn
Copy link
Member

Simn commented Jun 2, 2020

I still don't fully understand what this does. Am I supposed to just merge this and expect somebody to take care of it. :)

@RblSb
Copy link
Member Author

RblSb commented Jun 2, 2020

I did it for myself mostly, because setting up Azure CI for forks is problematic. If you fork repo on GitHub with GitHub CI - it just works for you. But there is still Linux js fail, have no idea what is wrong. Btw, i can remove Haxe script from this PR, because there is no more code duplication in compiled yaml file.

@nadako
Copy link
Member

nadako commented Jun 2, 2020

I'd say let's merge this and figure out JS issues later on development. I think the good plan is to stabilize Github CI and drop azure in favor of it after everything works.

@Simn Simn merged commit efbd40b into HaxeFoundation:development Jun 2, 2020
@Simn
Copy link
Member

Simn commented Jun 2, 2020

Alright then, let's see how this goes!

@RblSb RblSb deleted the github_actions branch June 2, 2020 16:01
back2dos pushed a commit to back2dos/haxe that referenced this pull request Oct 5, 2021
* Github actions

* Clean up

* Split neko installation to platform files

* Fix hl

best test is disabled test

* Windows hl fix

* Disable lua for windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants