Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java,cs] fix stack overflow from closures constraints #11350

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Oct 27, 2023

That change from #7863 doesn't seem needed (and seemed weird, even then) as tests added in the PR still pass, and was triggering a stack overflow (see forums)

I don't have a minimal repro for the stack overflow yet, will try to craft one and add as a test

class Main {
	public static function main() {}

	public static function forComparable<T : Comparable<T>>(): T->T->Void
		return (a: T, b: T) -> {}
}

typedef Comparable<T> = {
	public function compareTo(that : T) : Int;
}

@skial skial mentioned this pull request Oct 27, 2023
1 task
@kLabz kLabz added this to the 4.3 Hotfix candidates milestone Oct 27, 2023
@Simn Simn merged commit 039d30e into development Oct 27, 2023
@kLabz kLabz removed this from the 4.3 Hotfix candidates milestone Nov 14, 2023
kLabz added a commit that referenced this pull request Nov 14, 2023
* [java,cs] revert some change from 7863

* [tests] add test for stack overflow
0b1kn00b pushed a commit to 0b1kn00b/haxe that referenced this pull request Jan 25, 2024
…n#11350)

* [java,cs] revert some change from 7863

* [tests] add test for stack overflow
@kLabz kLabz deleted the fix/java-cs-stack-overflow branch May 28, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants