-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semaphores and condition variables. #10503
Semaphores and condition variables. #10503
Conversation
Nice! |
Changes to the ocaml version have been reverted. |
I think luv's synchronization primitives require explicit calls to |
I'm curious about the efficiency of these VS implementing them on top of Lock/Mutex :) |
Lock is already implemented using a semaphore on many targets. |
Sorry for the delay! I've merged the hxcpp PR, could you update this one so CI runs? Edit: Uhm, wrong PR, sorry! |
Now my last comment is accurate, so could you push again? I still don't know why I can't restart CI on this one. |
d4fbf84
to
cbcad6b
Compare
Can still be enabled with `HXCPP_WINXP_COMPAT`. Required for HaxeFoundation/haxe#10503.
|
Can still be enabled with `HXCPP_WINXP_COMPAT`. Required for HaxeFoundation/haxe#10503.
Also revert changes to Ocaml version.
Remove timing dependent test case that fails sometimes.
Remove commented out code from the .ml files.
cbcad6b
to
bdc548b
Compare
Had to restart CI again because |
Whatever, I'll just merge this! |
Since neko is deprecated I have not implemented these for neko.