Ssl: makefile add static mbedtls build #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt all mbedtls function been export
tobil4sk
reviewed
Sep 25, 2024
tobil4sk
reviewed
Sep 25, 2024
|
Thank you for the review and suggestions^^ I also think it's proper to use the main Makefile (and avoid copying cflags/lflags around). I can probably also reduce mbedtls |
tobil4sk
reviewed
Sep 27, 2024
yuxiaomao
changed the title
GlassySundew
pushed a commit
to GlassySundew/hashlink
that referenced
this pull request
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow building ssl.hdll with embedded mbedtls source from hashlink instead of system lib, with
make SSL_STATIC=1.This code is useful when the build machine does not have a recent version of mbedtls, and would like to use the one in hashlink - which might be more recent and more secure (e.g. for game distribution reason).
Tested on Linux and seems to work. Don't know how the mbedtls license works here, but it's already the case when building on Windows.