Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Vulkan or Metal request and don't force OpenGL #666

Merged
merged 6 commits into from
Apr 6, 2024

Conversation

onehundredfeet
Copy link
Contributor

To make adding Vulcan or metal easier, I removed the forced OpenGL specification on the window creation and only add it if neither Vulcan nor metal is added.

This will make it backwards compatible while also allowing Vulkan or Metal windows to be created.

@skial skial mentioned this pull request Mar 21, 2024
1 task
@onehundredfeet
Copy link
Contributor Author

onehundredfeet commented Mar 21, 2024

The checks are failing because Neko not installing.

Chocolatey installed 1/2 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - vcredist2015 (exited 1) - vcredist2015 not installed. An error occurred during installation:
 Error downloading 'vcredist2015.14.0.24215.20170201 : vcredist140 [14.0.24215.1, )' from 'https://community.chocolatey.org/api/v2/package/vcredist2015/14.0.24215.20170201'.

Unnecessary change to re-build.
@onehundredfeet
Copy link
Contributor Author

any chance of a merge?

@ncannasse
Copy link
Member

Look at the vulkan branch if you want to see how I did the SDL setup here : https://github.com/HaxeFoundation/hashlink/tree/vulkan
And this in particular
d15f466

@ncannasse ncannasse merged commit 1d54fc5 into HaxeFoundation:master Apr 6, 2024
4 of 8 checks passed
@onehundredfeet onehundredfeet deleted the sdl_metal_window branch April 6, 2024 12:55
@onehundredfeet
Copy link
Contributor Author

onehundredfeet commented Apr 6, 2024

It looks like the sdl_vulkan header is not available on the windows build machines. What's the best solution here?

  1. Guard using a define?
  2. Add the headers to the repo?
  3. Something else?

@yuxiaomao
Copy link
Collaborator

CI Fixed

GlassySundew pushed a commit to GlassySundew/hashlink that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants