-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for Vulkan or Metal request and don't force OpenGL #666
Merged
ncannasse
merged 6 commits into
HaxeFoundation:master
from
onehundredfeet:sdl_metal_window
Apr 6, 2024
Merged
Check for Vulkan or Metal request and don't force OpenGL #666
ncannasse
merged 6 commits into
HaxeFoundation:master
from
onehundredfeet:sdl_metal_window
Apr 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checks are failing because Neko not installing.
|
Unnecessary change to re-build.
any chance of a merge? |
Look at the vulkan branch if you want to see how I did the SDL setup here : https://github.com/HaxeFoundation/hashlink/tree/vulkan |
Required adding sdl_vulkan.h
It looks like the sdl_vulkan header is not available on the windows build machines. What's the best solution here?
|
CI Fixed |
GlassySundew
pushed a commit
to GlassySundew/hashlink
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make adding Vulcan or metal easier, I removed the forced OpenGL specification on the window creation and only add it if neither Vulcan nor metal is added.
This will make it backwards compatible while also allowing Vulkan or Metal windows to be created.