-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pcre2 #515
Merged
Merged
Migrate to pcre2 #515
Commits on Dec 1, 2022
-
This was done following the steps on in the `NON-AUTOTOOLS-BUILD` file found in the root of the pcre2 repository: https://github.com/PhilipHazel/pcre2/blob/pcre2-10.40/NON-AUTOTOOLS-BUILD
Configuration menu - View commit details
-
Copy full SHA for c66b180 - Browse repository at this point
Copy the full SHA c66b180View commit details -
Configuration menu - View commit details
-
Copy full SHA for 433b87f - Browse repository at this point
Copy the full SHA 433b87fView commit details -
CMake now has to specify each pcre file individually, as some are not meant to be compiled by themselves.
Configuration menu - View commit details
-
Copy full SHA for 12316a3 - Browse repository at this point
Copy the full SHA 12316a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0914c9d - Browse repository at this point
Copy the full SHA 0914c9dView commit details -
These were necessary in pcre1 but are handled by PCRE2_CODE_UNIT_WIDTH in pcre2
Configuration menu - View commit details
-
Copy full SHA for 04e78d5 - Browse repository at this point
Copy the full SHA 04e78d5View commit details -
Remove MATCH_LIMIT_DEPTH setting altogether
Since pcre 10.30, pcre2_match no longer uses recursive function calls, so this setting should no longer be needed. This avoids the memory leak caused by having to configure this setting using a context structure allocated at run time.
Configuration menu - View commit details
-
Copy full SHA for 31e7810 - Browse repository at this point
Copy the full SHA 31e7810View commit details -
Add
PCRE2_ALT_BSUX
to pcre pattern compilationThis is the pcre2 equivalent of the PCRE_JAVASCRIPT_COMPAT flag we used previously. Compare bullet point 4 of the pcre2 compatibility docs: https://www.pcre.org/current/doc/html/pcre2compat.html to bullet point 5 of the pcre1 compatibility docs: https://www.pcre.org/original/doc/html/pcrecompat.html
Configuration menu - View commit details
-
Copy full SHA for 734f2dc - Browse repository at this point
Copy the full SHA 734f2dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4101bc - Browse repository at this point
Copy the full SHA f4101bcView commit details -
Set other PCRE2 options for JavaScript compat
`PCRE2_ALT_BSUX`, `PCRE2_ALLOW_EMPTY_CLASS`, and `PCRE2_MATCH_UNSET_BACKREF` are equivalent to the old `PCRE_JAVASCRIPT_COMPAT`. See: https://lists.exim.org/lurker/message/20150105.162835.0666407a.en.html
Configuration menu - View commit details
-
Copy full SHA for 64ea8c6 - Browse repository at this point
Copy the full SHA 64ea8c6View commit details
Commits on Mar 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a545af5 - Browse repository at this point
Copy the full SHA a545af5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.