FlxPoint: Add setXY, deprecate one-arg set(x) #3490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
richTrash21
reviewed
Sep 28, 2025
| * | ||
| * @param n The X and Y coordinate of the point in space. | ||
| */ | ||
| public inline function setXY(n:Float):FlxBasePoint |
There was a problem hiding this comment.
Shouldn't function return FlxPoint instead of FlxBasePoint?
There was a problem hiding this comment.
Shouldn't function return
FlxPointinstead ofFlxBasePoint?
Both are the same, FlxBasePoint is the underlying type of FlxPoint
There was a problem hiding this comment.
Shouldn't function return
FlxPointinstead ofFlxBasePoint?Both are the same,
FlxBasePointis the underlying type ofFlxPoint
It still matters, this is a copy paste error, I think it's already fixed locally, but I'll check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
point.setXY(n)which is equivalent toset(n, n). also deprecates the single-arg use ofpoint.set(n)wherexis set tonandyis set to0.Eventually, in the next major version, set(x) will be deleted and in a later minor version it will be readded to behave like
setXYwhich will then be deprecated