Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small implementations for HaxeFlixel #2730

Closed
wants to merge 2 commits into from
Closed

Small implementations for HaxeFlixel #2730

wants to merge 2 commits into from

Conversation

Just-Feeshy
Copy link

The minor fix is to make the width for FlxText change the field width, too. When you decrease the regular width, the text won't be offset to the right.

@Geokureli Geokureli linked an issue Feb 14, 2023 that may be closed by this pull request
@Geokureli
Copy link
Member

Geokureli commented Feb 14, 2023

Currently haxeflixel has a problem where there is a confusing lack of distinction between a sprite's "graphic" size and it's "collision" size, and we're aiming to make them more distinct: #2667

I fear this is a step in the wrong direction, a text's collision width has different uses than it's graphical width. Also, it might be helpful for a majority of use-cases but I don't think we should make it more difficult to have a different fieldWidth and collision width.

also there's a lot of proposed changes that may make this change unnecessary very soon.

just use fieldWidth, especially if you're not colliding the text with anything

@Geokureli Geokureli closed this Feb 14, 2023
@Just-Feeshy
Copy link
Author

Thank you, I appreciate you bringing up the potential issues with the proposed change, and I will carefully consider the impacts before making further comments. Thank you for your feedback and understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlxText.width setter does not update underlying textField.width
2 participants