Save demo HTML5 fix #294
Merged
Save demo HTML5 fix #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing for unrelated network reasons, right now. i'll check in the morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to save, it either throws
this._gameSave.data.boxPositions[a] is undefinedorcan't convert undefined to object.It doesn't properly set the array on the dynamic object (
_gameSave.data/_gameSave.data.boxPositions). This just redoes a bit of the behaviour to set the array properly, by creating a temp one that DOES get properly pushed to with the box data.I think the code comment above the modified lines of code should also be changed as well to reflect the new behavious