Make timepickers adjust start and end time limits when picked

- Remove 'open' from event status change options and explain with notes
when not openable
- Remove crufty javascript that was breaking room removal

Schedule flow UI audit (rubycentral#261)

app/assets/javascripts/staff/program/time-slot.js

@@ -16,9 +16,25 @@
   }
 
   function initTimePickers() {
-    $('#time_slot_start_time, #time_slot_end_time').timepicker({
-      timeFormat: 'HH:mm',
-      stepMinute: 5
+    $('#time_slot_start_time').timepicker({
+      controlType: 'select',
+      timeFormat: 'h:mm tt',
+      stepMinute: 5,
+      maxTime: $('#time_slot_end_time').val(),
+      onSelect: function(time) {
+        $('#time_slot_end_time').timepicker('destroy');
+        initTimePickers();
+      }
+    });
+    $('#time_slot_end_time').timepicker({
+      controlType: 'select',
+      timeFormat: 'h:mm tt',
+      stepMinute: 5,
+      minTime: $('#time_slot_start_time').val(),
+      onSelect: function(time) {
+        $('#time_slot_start_time').timepicker('destroy');
+        initTimePickers();
+      }
     });
   }
 

app/controllers/staff/events_controller.rb

@@ -58,6 +58,10 @@ def update_status
       redirect_to event_staff_info_path(@event), notice: "Event status was successfully updated."
     else
       flash[:danger] = "There was a problem updating the event status. Please try again."
+      flash[:danger] += @event.errors.messages.values.flatten.map do |m|
+        " <br>#{m}"
+      end.join if @event.errors.present?
+      @event.reload
       render :info
     end
   end

app/decorators/staff/time_slot_decorator.rb

@@ -3,11 +3,11 @@ class Staff::TimeSlotDecorator < Draper::Decorator
   delegate_all
 
   def start_time
-    object.start_time.try(:to_s, :time)
+    object.start_time.try(:to_s, :time_p)
   end
 
   def end_time
-    object.end_time.try(:to_s, :time)
+    object.end_time.try(:to_s, :time_p)
   end
 
   def session_duration

app/helpers/events_helper.rb

@@ -0,0 +1,16 @@
+module EventsHelper
+  def event_status_options(event)
+    statuses = Event::STATUSES.values
+    if event.public_session_formats.empty? || event.guidelines.blank?
+      statuses.delete(Event::STATUSES[:open])
+    end
+    options_for_select(statuses, event.status)
+  end
+
+  def event_status_messages(event)
+    messages = []
+    messages << Event::SESSION_FORMAT_MESSAGE if event.public_session_formats.empty?
+    messages << Event::GUIDELINE_MESSAGE if event.guidelines.blank?
+    messages
+  end
+end

app/models/event.rb

@@ -1,4 +1,8 @@
 class Event < ApplicationRecord
+
+  GUIDELINE_MESSAGE = 'Guidelines must be defined before event can be opened.'
+  SESSION_FORMAT_MESSAGE = 'At least one public session format must be defined before event can be opened.'
+
   has_many :teammates, dependent: :destroy
   has_many :proposals, dependent: :destroy
   has_many :speakers
@@ -46,8 +50,8 @@ def to_param
   end
 
   with_options on: :update, if: :open? do
-    validates :public_session_formats, presence: { message: 'A least one public session format must be defined before event can be opened.' }
-    validates :guidelines, presence: { message: 'Guidelines must be defined before event can be opened.' }
+    validates :public_session_formats, presence: { message: SESSION_FORMAT_MESSAGE }
+    validates :guidelines, presence: { message: GUIDELINE_MESSAGE }
   end
 
   def initialize_speaker_emails

app/models/time_slot.rb

@@ -19,6 +19,8 @@ class TimeSlot < ApplicationRecord
   end
   scope :grid_order, -> { joins(:room).order(:conference_day, :start_time, 'rooms.grid_position') }
 
+  validate :end_time_later_than_start_time
+
   def self.import(file)
     raw_json = file.read # maybe open as well
     parsed_slots = JSON.parse(raw_json)
@@ -92,6 +94,12 @@ def session_confirmation_notes
   def session_duration
     (end_time - start_time).to_i/60
   end
+
+  def end_time_later_than_start_time
+    if session_duration <= 0
+      errors.add(:end_time, 'must be later than start time')
+    end
+  end
 end
 
 # == Schema Information

app/views/staff/events/info.html.haml

@@ -11,8 +11,10 @@
               = link_to "Edit Info", event_staff_edit_path(event), class: "btn btn-primary"
               = link_to "Change Status", '#', class: "btn btn-primary status-button"
             .status-dropdown.pull-right
+              - event_status_messages(event).each do |message|
+                .message= "Note: #{message}"
               = form_for(event, url: event_staff_update_status_path(event)) do |f|
-                = f.select(:state, options_for_select(Event::STATUSES.values, f.object.state))
+                = f.select(:state, event_status_options(event))
                 = link_to "Cancel", '#', {:class=>"cancel-status-change btn btn-danger"}
                 = f.submit "Update Status", class: "btn btn-success"
         %h1 Event Info

app/views/staff/rooms/destroy.js.erb

@@ -1,5 +1,4 @@
 $('table#organizer-rooms #room_<%= room.id %>').remove();
-window.Schedule.TimeSlots.reloadTable(<%=raw time_slots.rows.to_json %>);
 
 <% if has_missing_requirements?(room.event) %>
   $('#time-slot-prereqs').removeClass('hidden');

config/initializers/time_formats.rb

@@ -4,4 +4,4 @@
 Time::DATE_FORMATS[:month_day] = "%b %d"
 Time::DATE_FORMATS[:db_just_date] = "%Y-%m-%d"
 Time::DATE_FORMATS[:event_day] = "%A, %b %d"
-Time::DATE_FORMATS[:time_p] = "%H:%M%p"
+Time::DATE_FORMATS[:time_p] = "%l:%M %P"