Skip to content

feat(feature-activation): add new states to design#58

Merged
glevco merged 3 commits intomasterfrom
feat/feature-activation/new-states
Jul 6, 2023
Merged

feat(feature-activation): add new states to design#58
glevco merged 3 commits intomasterfrom
feat/feature-activation/new-states

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jun 22, 2023

This design update takes the two feature states that were originally left as "future improvements" and describe their implementation. They were left out for simplification, but during the implementation phase, we noticed that they would be useful, specially when dealing with reorgs.

Acceptance Criteria

  • Add MUST_SIGNAL and LOCKED_IN states
  • Other updates made to reflect the actual code implementation

@glevco glevco marked this pull request as ready for review June 22, 2023 14:58
@glevco glevco requested review from jansegre and msbrogli June 22, 2023 14:59
@glevco glevco self-assigned this Jun 22, 2023
@glevco glevco added the rfc label Jun 22, 2023
@glevco glevco merged commit e115c6c into master Jul 6, 2023
@glevco glevco deleted the feat/feature-activation/new-states branch July 6, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants