Skip to content

perf(daemon): fire-and-forget sendRealtimeTx #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreabadesso wants to merge 3 commits into
base: master
Choose a base branch
from
Open

perf(daemon): fire-and-forget sendRealtimeTx #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bef91a1
perf(daemon): fire-and-forget sendRealtimeTx
andreabadesso Apr 17, 2026
df4ace9
test(daemon): fix sendRealtimeTx mocks in integration tests
andreabadesso Apr 20, 2026
36187b1
Merge remote-tracking branch 'origin/master' into perf/daemon-async-s…
andreabadesso Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/daemon/__tests__/integration/balances.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jest.mock('../../src/config', () => {

jest.mock('../../src/utils/aws', () => {
return {
sendRealtimeTx: jest.fn(),
sendRealtimeTx: jest.fn().mockResolvedValue(undefined),
invokeOnTxPushNotificationRequestedLambda: jest.fn(),
};
});
Expand Down
2 changes: 1 addition & 1 deletion packages/daemon/__tests__/integration/token_created_hybrid_with_reorg.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jest.mock('../../src/config', () => {

jest.mock('../../src/utils/aws', () => {
return {
sendRealtimeTx: jest.fn(),
sendRealtimeTx: jest.fn().mockResolvedValue(undefined),
invokeOnTxPushNotificationRequestedLambda: jest.fn(),
};
});
Expand Down
2 changes: 1 addition & 1 deletion packages/daemon/__tests__/integration/token_creation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jest.mock('../../src/config', () => {

jest.mock('../../src/utils/aws', () => {
return {
sendRealtimeTx: jest.fn(),
sendRealtimeTx: jest.fn().mockResolvedValue(undefined),
invokeOnTxPushNotificationRequestedLambda: jest.fn(),
};
});
Expand Down
1 change: 1 addition & 0 deletions packages/daemon/__tests__/services/services.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ jest.mock('../../src/utils', () => ({
getFullnodeHttpUrl: jest.fn(),
invokeOnTxPushNotificationRequestedLambda: jest.fn(),
sendMessageSQS: jest.fn(),
sendRealtimeTx: jest.fn().mockResolvedValue(undefined),
getWalletBalancesForTx: jest.fn(),
generateAddresses: jest.fn(),
retryWithBackoff: jest.fn((fn) => fn()),
Expand Down
19 changes: 9 additions & 10 deletions packages/daemon/src/services/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,16 +528,15 @@ export const handleVertexAccepted = async (context: Context, _event: Event) => {
signal_bits: 0, // TODO: we should actually receive this and store in the database
};

try {
if (seenWallets.length > 0) {
await sendRealtimeTx(
Array.from(seenWallets),
txData,
);
}
} catch (e) {
logger.error('Failed to send transaction to SQS queue');
logger.error(e);
// Fire-and-forget: SQS publish is a best-effort real-time
// notification and must not block the handler. Matches the pattern
// used for invokeOnTxPushNotificationRequestedLambda below.
if (seenWallets.length > 0) {
sendRealtimeTx(Array.from(seenWallets), txData)
.catch((err: Error) => {
logger.error('Failed to send transaction to SQS queue');
logger.error(err);
});
}

try {
Expand Down
Loading