Skip to content

fix: add error logging to silent catch blocks in API handlers #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreabadesso merged 2 commits into from
Apr 9, 2026
Merged

fix: add error logging to silent catch blocks in API handlers #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5949059
fix: add error logging to silent catch blocks in API handlers
andreabadesso Apr 8, 2026
23129af
Merge branch 'master' into fix/add-error-logging-to-silent-catch-blocks
andreabadesso Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/wallet-service/src/api/pushRegister.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import cors from '@middy/http-cors';
import Joi, { ValidationError } from 'joi';
import { PushRegister } from '@src/types';
import errorHandler from '@src/api/middlewares/errorHandler';
import createDefaultLogger from '@src/logger';

const mysql = getDbConnection();

Expand Down Expand Up @@ -86,6 +87,12 @@ export const register: APIGatewayProxyHandler = middy(walletIdProxyHandler(async

await commitTransaction(mysql);
} catch (e) {
const logger = createDefaultLogger();
logger.error('Failed to register push device', {
walletId,
deviceId: body.deviceId,
error: e.message,
});
await rollbackTransaction(mysql);
return closeDbAndGetError(mysql, ApiError.UNKNOWN_ERROR, { message: e.message });
}
Expand Down
6 changes: 6 additions & 0 deletions packages/wallet-service/src/api/txProposalDestroy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { closeDbAndGetError } from '@src/api/utils';
import middy from '@middy/core';
import cors from '@middy/http-cors';
import errorHandler from '@src/api/middlewares/errorHandler';
import createDefaultLogger from '@src/logger';

const mysql = getDbConnection();

Expand Down Expand Up @@ -70,6 +71,11 @@ export const destroy: APIGatewayProxyHandler = middy(walletIdProxyHandler(async

await commitTransaction(mysql);
} catch (e) {
const logger = createDefaultLogger();
logger.error('Failed to destroy tx proposal', {
txProposalId,
error: e.message,
});
await rollbackTransaction(mysql);
return closeDbAndGetError(mysql, ApiError.UNKNOWN_ERROR, { message: e.message });
}
Expand Down
5 changes: 5 additions & 0 deletions packages/wallet-service/src/commons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ import {
import { addAlert } from '@wallet-service/common/src/utils/alerting.utils';

import { isTxVoided } from '@src/utils';
import createDefaultLogger from '@src/logger';

import hathorLib from '@hathor/wallet-lib';
import { stringMapIterator, WalletBalanceMapConverter } from '@src/db/utils';
Expand Down Expand Up @@ -551,11 +552,15 @@ export const handleReorg = async (mysql: ServerlessMysql, logger: Logger): Promi

export const walletIdProxyHandler = (handler: WalletProxyHandler): APIGatewayProxyHandler => (
async (event, context) => {
const logger = createDefaultLogger();
let walletId: string;
try {
walletId = event.requestContext.authorizer.principalId;
// validate walletId?
} catch (e) {
logger.error('Failed to extract walletId from authorization context', {
error: e.message,
});
return {
statusCode: 401,
body: 'Unauthorized',
Expand Down
Loading