feat: include genesisBlockHash in version endpoint response#385
feat: include genesisBlockHash in version endpoint response#385andreabadesso merged 1 commit intomasterfrom
Conversation
The convertApiVersionData function was dropping the genesis_block_hash field from the fullnode response. This field is needed by the mobile wallet to persist registered tokens per network across network changes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughA new optional field Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the high-level summary generated by CodeRabbit.Configure the |
Motivation
The
/versionendpoint was droppinggenesis_block_hashfrom the fullnode response during conversion. The mobile wallet needs this field to persist registered tokens per network across network changes.Acceptance Criteria
/versionendpoint response includesgenesisBlockHashfieldgenesisBlockHashisnullwhen the fullnode does not provide it (older versions)Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets mergedSummary by CodeRabbit