fix: allow numeric lockExpires in push notification validation

[andreabadesso]

Summary

• Fixes Opsgenie alert #50062: "Invalid payload while handling push notification request"
• The Joi schema used .valid(null) for lockExpires, which creates a whitelist accepting only null — rejecting valid numeric timestamps from time-locked outputs
• Changed to .allow(null) so both null and non-negative integers are accepted
• Added test case for numeric lockExpires values

Test plan

• Verify existing push notification tests still pass
• Confirm the new test with numeric lockExpires passes
• Deploy and verify the Opsgenie alert stops recurring

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Fixed wallet service validation to properly accept null values for lock expiration timestamps in push notification requests.

• Tests

  • Added test coverage to verify correct handling and processing of expiration timestamps in push notifications.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 96c8e563-7a9d-4f11-87a6-bdea33c8a3c8

📥 Commits

Reviewing files that changed from the base of the PR and between 1693af7 and 23915b5.

📒 Files selected for processing (2)

• packages/wallet-service/src/api/txPushNotificationRequested.ts
• packages/wallet-service/tests/txPushNotificationRequested.test.ts

---

📝 Walkthrough

Walkthrough

This change modifies the wallet service's transaction push notification API by adjusting how null values are validated for the lockExpires parameter using Joi's .allow(null) method, and adds a new test suite validating that numeric lockExpires timestamps are accepted and trigger push notifications correctly.

Changes

Cohort / File(s)	Summary
Validation Method Update packages/wallet-service/src/api/txPushNotificationRequested.ts	Changed lockExpires validation from .valid(null) to .allow(null) to modify how null values are permitted while maintaining numeric and minimum constraints.
Test Suite Addition packages/wallet-service/tests/txPushNotificationRequested.test.ts	Added "validation lockExpires" test suite with tests verifying that numeric epoch lockExpires values are accepted and trigger exactly one push notification invocation (with test block duplication).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A rabbit hops through validation schemes,
Where lockExpires now flows through Joi's streams,
From .valid(null) to .allow() we change,
Tests multiply to keep things in range! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: allowing numeric lockExpires values in push notification validation by changing the Joi schema validation rule.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/push-notification-lockExpires-validation

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}