Skip to content

Merge release v1.12.0 into master#379

Merged
andreabadesso merged 9 commits intomasterfrom
release
Mar 5, 2026
Merged

Merge release v1.12.0 into master#379
andreabadesso merged 9 commits intomasterfrom
release

Conversation

@andreabadesso
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso commented Mar 5, 2026

Motivation

Merge the release branch back into master to bring in the bugfix that was applied directly to release-candidate during the v1.12.0 release cycle:

Acceptance Criteria

  • master contains all fixes applied during the release cycle

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

Summary by CodeRabbit

  • Bug Fixes

    • Improved event tracking reliability by enabling fallback logic when primary event data is unavailable.
  • New Features

    • Added endpoint to check for transactions outside the primary wallet address, accessible to read-only authentication tokens.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 91c00a98-7107-47cc-9a13-a27316366efb

📥 Commits

Reviewing files that changed from the base of the PR and between 82a94dd and 9c62cc3.

📒 Files selected for processing (3)
  • packages/daemon/__tests__/services/services.test.ts
  • packages/daemon/src/services/index.ts
  • packages/wallet-service/src/api/auth.ts

📝 Walkthrough

Walkthrough

Three files modified: test suite updated for checkForMissedEvents to validate handling of initialEventId as a fallback source; service implementation refactored to derive lastAckEventId from either context.event?.event.id or context.initialEventId; authentication policy extended to include new wallet endpoint.

Changes

Cohort / File(s) Summary
checkForMissedEvents Tests
packages/daemon/__tests__/services/services.test.ts
Renamed failing test case and updated error message to clarify "No event in context and no initialEventId" scenario. Added new test verifying initialEventId is used as fallback for last_ack_event_id parameter when context.event is null, with size=1 and hasNewEvents returning false.
checkForMissedEvents Service Logic
packages/daemon/src/services/index.ts
Refactored to derive lastAckEventId from context.event?.event.id with fallback to context.initialEventId. Added combined null/undefined guard with updated error message. Maintains existing request logic and retry behavior.
Wallet Auth Policy
packages/wallet-service/src/api/auth.ts
Added endpoint wallet/addresses/has-transactions-outside-first-address to read-only (ro) policy resource set and allowedResources array for read-only token access.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • pedroferreira1
  • raul-oliveira

Poem

🐰 A fallback path emerges clear,
When context events disappear,
initialEventId saves the day,
And wallets now have safer way,
Tests confirm the logic's right! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Merge release v1.12.0 into master' accurately describes the primary intent: merging a release branch into the master branch. It is specific, clear, and directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release

Comment @coderabbitai help to get the list of available commands and usage tips.

@andreabadesso andreabadesso self-assigned this Mar 5, 2026
@andreabadesso andreabadesso added the enhancement New feature or request label Mar 5, 2026
@andreabadesso andreabadesso moved this to In Progress (Done) in Hathor Network Mar 5, 2026
@github-project-automation github-project-automation Bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 5, 2026
@andreabadesso andreabadesso merged commit c79157c into master Mar 5, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Mar 5, 2026
@andreabadesso andreabadesso moved this from Waiting to be deployed to Done in Hathor Network Mar 5, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Apr 13, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants