feat: store first_block on transactions#350
Merged
Merged
Conversation
b1596c2 to
55117a0
Compare
andreabadesso
commented
Jan 27, 2026
| return { | ||
| error: 'checkAddressTable query', | ||
| params: { txId, timestamp, version, voided, height }, | ||
| error: 'checkTransactionTable query', |
Collaborator
Author
There was a problem hiding this comment.
Thanks Claude
r4mmer
previously approved these changes
Jan 27, 2026
pedroferreira1
previously approved these changes
Jan 28, 2026
d963ba2
pedroferreira1
approved these changes
Jan 28, 2026
r4mmer
approved these changes
Jan 28, 2026
This was referenced Jan 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles
first_blockchanges (by storing them in thetransactiontable) and also handles multiple changes in a transaction metadata in the same eventMotivation
After adding the
first_blockhandling mechanism, we stopped handlingnc_executionchanges, upon investigation I've noticed that we were expecting oneMETADATA_CHANGEDevent for each change which is not what actually happens -- we receive a single metadata changed event with all changes to metadataAcceptance Criteria
metadataDiffdetects all independent metadata changes in a single event and returns them as an arrayhandleNcExecVoidedno longer needs to know aboutfirst_block— each handler has a single responsibilityfirst_blockis now atransactioncolumn and gets handled by the new metadata diffChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged