feat(wallet-service): added an api to find out if a wallet is using m…#339
Merged
andreabadesso merged 5 commits intomasterfrom Jan 19, 2026
Merged
feat(wallet-service): added an api to find out if a wallet is using m…#339andreabadesso merged 5 commits intomasterfrom
andreabadesso merged 5 commits intomasterfrom
Conversation
…ore than one address
tuliomir
previously approved these changes
Jan 19, 2026
| handler: src/api/hasNonFirstAddressTransactions.get | ||
| events: | ||
| - http: | ||
| path: wallet/addresses/has-transactions |
Contributor
There was a problem hiding this comment.
suggestion: The has-transactions endpoint name is misleading. I would expect it to return just if a wallet has been used at all, not if it is a single address wallet.
I would suggest something along the lines of:
has-many-addressesor justwallet/addresses/has-manyhas-transactions-on-multiple-addressesis-single-address-walletis-candidate-single-address-wallethas-transactions-outside-first-address
pedroferreira1
previously approved these changes
Jan 19, 2026
ecb970b
tuliomir
approved these changes
Jan 19, 2026
pedroferreira1
approved these changes
Jan 19, 2026
This was referenced Jan 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The idea here is to allow the web-wallet to reject user requests to use the "single address" feature if the user wallet has more than one address being used
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged