Skip to content

feat(wallet-service): added an api to find out if a wallet is using m…#339

Merged
andreabadesso merged 5 commits intomasterfrom
feat/tx-on-non-first-addresses
Jan 19, 2026
Merged

feat(wallet-service): added an api to find out if a wallet is using m…#339
andreabadesso merged 5 commits intomasterfrom
feat/tx-on-non-first-addresses

Conversation

@andreabadesso
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso commented Jan 8, 2026

Motivation

The idea here is to allow the web-wallet to reject user requests to use the "single address" feature if the user wallet has more than one address being used

Acceptance Criteria

  • We must have an API that returns whether a wallet has transactions in addresses other than the first one

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso moved this from Todo to In Progress (WIP) in Hathor Network Jan 16, 2026
@andreabadesso andreabadesso added the enhancement New feature or request label Jan 19, 2026
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jan 19, 2026
tuliomir
tuliomir previously approved these changes Jan 19, 2026
Comment thread packages/wallet-service/serverless.yml Outdated
handler: src/api/hasNonFirstAddressTransactions.get
events:
- http:
path: wallet/addresses/has-transactions
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: The has-transactions endpoint name is misleading. I would expect it to return just if a wallet has been used at all, not if it is a single address wallet.

I would suggest something along the lines of:

  • has-many-addresses or just wallet/addresses/has-many
  • has-transactions-on-multiple-addresses
  • is-single-address-wallet
  • is-candidate-single-address-wallet
  • has-transactions-outside-first-address

@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jan 19, 2026
pedroferreira1
pedroferreira1 previously approved these changes Jan 19, 2026
@pedroferreira1 pedroferreira1 moved this from In Review (WIP) to In Review (Done) in Hathor Network Jan 19, 2026
@andreabadesso andreabadesso dismissed stale reviews from pedroferreira1 and tuliomir via ecb970b January 19, 2026 14:35
@tuliomir tuliomir moved this from In Review (Done) to In Review (WIP) in Hathor Network Jan 19, 2026
@tuliomir tuliomir moved this from In Review (WIP) to In Review (Done) in Hathor Network Jan 19, 2026
@andreabadesso andreabadesso merged commit a850d21 into master Jan 19, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jan 19, 2026
@andreabadesso andreabadesso mentioned this pull request Jan 28, 2026
2 tasks
@andreabadesso andreabadesso moved this from Waiting to be deployed to Done in Hathor Network Jan 28, 2026
This was referenced Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants