feat(wallet-service): added a new param to the getUtxos endpoint to …#329
Merged
andreabadesso merged 9 commits intomasterfrom Jan 28, 2026
Merged
feat(wallet-service): added a new param to the getUtxos endpoint to …#329andreabadesso merged 9 commits intomasterfrom
andreabadesso merged 9 commits intomasterfrom
Conversation
…eturn utxos that fit inside the requested value
andreabadesso
moved this from In Progress (WIP)
to In Progress (Done)
in Hathor Network
Signed-off-by: André Abadesso <andre.abadesso@gmail.com>
pedroferreira1
previously approved these changes
Dec 23, 2025
r4mmer
reviewed
Dec 26, 2025
Comment on lines
+233
to
+234
| // txOutputs are sorted by value DESC from the database, so we iterate | ||
| // from smallest to largest to maximize the number of UTXOs within the limit |
Member
There was a problem hiding this comment.
Why do we want to "maximize" the number of utxos?
In the wallet-lib when an amount limit is given we usually try to select as few utxos as possible to avoid hitting the tx input limit (255)
Collaborator
Author
There was a problem hiding this comment.
You are right, refactored it to invert the logic
r4mmer
reviewed
Jan 28, 2026
Member
There was a problem hiding this comment.
I believe this should not be commited
Member
There was a problem hiding this comment.
I believe this should not have been commited as well
andreabadesso
force-pushed
the
feat/max-amount
branch
from
4e27c2f to
3945546
Compare
pedroferreira1
approved these changes
Jan 28, 2026
r4mmer
approved these changes
Jan 28, 2026
github-project-automation
Bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
github-project-automation
Bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
This was referenced Jan 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The totalAmount parameter returns UTXOs summing to at least the specified amount (for transaction building).
Users needed a way to query UTXOs with an upper bound, returning UTXOs summing to at most a specified amount.
Acceptance Criteria
/wallet/tx_outputsand/wallet/utxosendpointstotalAmountandmaxAmountare provided simultaneouslyChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged