fix: consider Serverless prefix when invoking functions#307
Merged
Conversation
3bb9589 to
d276a91
Compare
andreabadesso
previously approved these changes
Nov 3, 2025
d276a91 to
94128d6
Compare
969f372 to
5369b03
Compare
andreabadesso
approved these changes
Nov 4, 2025
tuliomir
approved these changes
Nov 4, 2025
| testnetindia_PUSH_NOTIFICATION_ENABLED: "true" | ||
| testnetindia_PUSH_ALLOWED_PROVIDERS: "android,ios" | ||
| testnetindia_APPLICATION_NAME: "wallet-service-testnet-india" | ||
| testnetindia_SERVERLESS_DEPLOY_PREFIX: "wallet-service" |
Contributor
There was a problem hiding this comment.
question(non-blocking): Just double-checking that we won't be using the default 'hathor-wallet-service' prefix for testnet-india, right?
Collaborator
Author
There was a problem hiding this comment.
Right, it was the first one where I tested a custom prefix
This was referenced Nov 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some parts of the code have hardcoded function prefixes, and we recently started allowing customizable prefixes
Acceptance Criteria
hathor-wallet-serviceTODO
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged