Skip to content

fix: consider Serverless prefix when invoking functions#307

Merged
luislhl merged 1 commit intomasterfrom
fix/serverless-prefix
Nov 5, 2025
Merged

fix: consider Serverless prefix when invoking functions#307
luislhl merged 1 commit intomasterfrom
fix/serverless-prefix

Conversation

@luislhl
Copy link
Copy Markdown
Collaborator

@luislhl luislhl commented Nov 3, 2025

Motivation

Some parts of the code have hardcoded function prefixes, and we recently started allowing customizable prefixes

Acceptance Criteria

  • The wallet-service and daemon packages should read the env var used to configure the prefix, with a default of hathor-wallet-service

TODO

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl self-assigned this Nov 3, 2025
@luislhl luislhl moved this from Todo to In Progress (WIP) in Hathor Network Nov 3, 2025
@luislhl luislhl force-pushed the fix/serverless-prefix branch from 3bb9589 to d276a91 Compare November 3, 2025 21:17
andreabadesso
andreabadesso previously approved these changes Nov 3, 2025
@luislhl luislhl force-pushed the fix/serverless-prefix branch from 969f372 to 5369b03 Compare November 4, 2025 14:40
@luislhl luislhl moved this from In Progress (WIP) to In Review (WIP) in Hathor Network Nov 4, 2025
@luislhl luislhl requested review from tuliomir and removed request for pedroferreira1 November 4, 2025 14:42
Comment thread .codebuild/buildspec.yml
testnetindia_PUSH_NOTIFICATION_ENABLED: "true"
testnetindia_PUSH_ALLOWED_PROVIDERS: "android,ios"
testnetindia_APPLICATION_NAME: "wallet-service-testnet-india"
testnetindia_SERVERLESS_DEPLOY_PREFIX: "wallet-service"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question(non-blocking): Just double-checking that we won't be using the default 'hathor-wallet-service' prefix for testnet-india, right?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it was the first one where I tested a custom prefix

@luislhl luislhl moved this from In Review (WIP) to In Review (Done) in Hathor Network Nov 4, 2025
@luislhl luislhl merged commit bb97797 into master Nov 5, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Nov 5, 2025
@luislhl luislhl deleted the fix/serverless-prefix branch November 5, 2025 16:24
@luislhl luislhl moved this from Waiting to be deployed to Done in Hathor Network Nov 5, 2025
This was referenced Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants