Merged
Conversation
pedroferreira1
previously approved these changes
Oct 10, 2025
| @@ -0,0 +1,3 @@ | |||
| import { stopGLLBackgroundTask } from '@hathor/wallet-lib'; | |||
Collaborator
There was a problem hiding this comment.
Missing hathor header
| @@ -0,0 +1,6 @@ | |||
| import { stopGLLBackgroundTask } from '@hathor/wallet-lib'; | |||
Collaborator
There was a problem hiding this comment.
Missing hathor header
pedroferreira1
moved this from In Progress (Done)
to In Review (Done)
in Hathor Network
pedroferreira1
approved these changes
Oct 10, 2025
andreabadesso
approved these changes
Oct 10, 2025
github-project-automation
Bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
github-project-automation
Bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
This was referenced Nov 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The wallet-lib start a background task that prevents jest from finishing properly.
The lib (after v2.8.X) exports a method to stop this task so we should use it.
Acceptance Criteria
stopGLLBackgroundTaskbefore all testsChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged