Skip to content

feat(wallet-service): added read-only authorizer and api#299

Merged
andreabadesso merged 4 commits intomasterfrom
feat/read-only-auth
Oct 9, 2025
Merged

feat(wallet-service): added read-only authorizer and api#299
andreabadesso merged 4 commits intomasterfrom
feat/read-only-auth

Conversation

@andreabadesso
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso commented Oct 8, 2025

Implements https://github.com/HathorNetwork/internal-rfcs/pull/39

Acceptance Criteria

  • We must be able to generate JWTs for read-only wallets (using xpubkeys)
  • Wallets must be in the READY state in order to authenticate, we must error otherwise.
  • APIs that mutate database state must be marked as write and we should reject requests made using a read-only JWT.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Oct 8, 2025
@andreabadesso andreabadesso added the enhancement New feature or request label Oct 8, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (WIP) in Hathor Network Oct 8, 2025
@andreabadesso andreabadesso force-pushed the feat/read-only-auth branch 9 times, most recently from e2c6779 to 24b5362 Compare October 8, 2025 20:20
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Oct 8, 2025
r4mmer
r4mmer previously approved these changes Oct 9, 2025
pedroferreira1
pedroferreira1 previously approved these changes Oct 9, 2025
Comment thread packages/wallet-service/src/api/auth.ts Outdated
@github-project-automation github-project-automation Bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Oct 9, 2025
@pedroferreira1 pedroferreira1 moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 9, 2025
@andreabadesso andreabadesso dismissed stale reviews from pedroferreira1 and r4mmer via 1e646ed October 9, 2025 18:37
@github-project-automation github-project-automation Bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Oct 9, 2025
@andreabadesso andreabadesso merged commit 24ddc18 into master Oct 9, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Oct 9, 2025
@andreabadesso andreabadesso deleted the feat/read-only-auth branch October 9, 2025 19:13
This was referenced Nov 17, 2025
@andreabadesso andreabadesso moved this from Waiting to be deployed to Done in Hathor Network Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants