Skip to content

fix: nano contracts enabled string#297

Merged
andreabadesso merged 4 commits intomasterfrom
fix/nano-contracts-enabled-string
Sep 25, 2025
Merged

fix: nano contracts enabled string#297
andreabadesso merged 4 commits intomasterfrom
fix/nano-contracts-enabled-string

Conversation

@andreabadesso
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso commented Sep 25, 2025

Acceptance Criteria

  • Wallet-service /version endpoint returns nanoContractsEnabled boolean field
  • Handles fullnode API bug where field may be string values ('disabled', 'enabled', 'feature_activation') instead of boolean
  • Properly maps values: true/'enabled'/'feature_activation' → true, everything else → false
  • Includes validation, type definitions, and comprehensive test coverage

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Sep 25, 2025
@andreabadesso andreabadesso added the bug Something isn't working label Sep 25, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (Done) in Hathor Network Sep 25, 2025
@github-project-automation github-project-automation Bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 25, 2025
@andreabadesso andreabadesso merged commit 6330344 into master Sep 25, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Sep 25, 2025
This was referenced Nov 17, 2025
@andreabadesso andreabadesso moved this from Waiting to be deployed to Done in Hathor Network Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants