Skip to content

chore: avoid false positive alerts on duplicate tx#292

Merged
luislhl merged 1 commit intomasterfrom
chore/avoid-false-positive-alerts-on-duplicate-tx
Sep 19, 2025
Merged

chore: avoid false positive alerts on duplicate tx#292
luislhl merged 1 commit intomasterfrom
chore/avoid-false-positive-alerts-on-duplicate-tx

Conversation

@luislhl
Copy link
Copy Markdown
Collaborator

@luislhl luislhl commented Sep 18, 2025

Motivation

We receive a false positive alert every time a daemon is restarted in some environment

Acceptance Criteria

  • Only log an error about duplicate transaction if the daemon has not been restarted recently

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl self-assigned this Sep 18, 2025
@luislhl luislhl moved this from Todo to In Progress (Done) in Hathor Network Sep 18, 2025
@luislhl luislhl requested a review from tuliomir September 18, 2025 20:47
@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 18, 2025
@andreabadesso andreabadesso moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 19, 2025
@luislhl luislhl merged commit ac7e865 into master Sep 19, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Sep 19, 2025
@luislhl luislhl deleted the chore/avoid-false-positive-alerts-on-duplicate-tx branch September 19, 2025 16:51
@luislhl luislhl mentioned this pull request Nov 17, 2025
2 tasks
@luislhl luislhl moved this from Waiting to be deployed to Done in Hathor Network Nov 17, 2025
@luislhl luislhl mentioned this pull request Nov 21, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants