chore: warmup middleware for authorization lambdas#287
Merged
Conversation
r4mmer
commented
Sep 9, 2025
Comment on lines
+108
to
+110
| z.object({ | ||
| token_data: z.number().nullish(), | ||
| }).strict() |
Member
Author
There was a problem hiding this comment.
There was an event from the simulator with { token_data: 0 } which would break the parser, so I added this option.
Collaborator
There was a problem hiding this comment.
I solved it differently in https://github.com/HathorNetwork/hathor-wallet-service/pull/281/files#r2334854251, what do you think?
Member
Author
There was a problem hiding this comment.
Changed to be the same as yours since it acomplishes the same thing and makes conflict resolution easier
r4mmer
commented
Sep 9, 2025
Comment on lines
+87
to
+96
| if (!wallet) { | ||
| await closeDbConnection(mysql); | ||
| return { | ||
| statusCode: 400, | ||
| body: JSON.stringify({ | ||
| success: false, | ||
| error: ApiError.WALLET_NOT_FOUND, | ||
| }), | ||
| }; | ||
| } |
Member
Author
There was a problem hiding this comment.
Just including an error treatment in case we don't find the wallet.
pedroferreira1
previously approved these changes
Sep 9, 2025
andreabadesso
previously approved these changes
Sep 10, 2025
pedroferreira1
previously approved these changes
Sep 10, 2025
andreabadesso
previously approved these changes
Sep 10, 2025
github-project-automation
Bot
moved this from In Review (Done)
to In Review (WIP)
in Hathor Network
r4mmer
dismissed stale reviews from andreabadesso and pedroferreira1
via
fdf6f14
andreabadesso
approved these changes
Sep 10, 2025
pedroferreira1
approved these changes
Sep 10, 2025
github-project-automation
Bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
This was referenced Nov 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Having both the auth token api and the authorizer lambda cold start at the same time increases the wallet start by more than 2 seconds.
Having them always be warmed would improve the UX.
Acceptance Criteria
Extra chores
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged