Skip to content

fix: send nano tx#276

Merged
andreabadesso merged 6 commits intomasterfrom
fix/send-nano-tx
Aug 5, 2025
Merged

fix: send nano tx#276
andreabadesso merged 6 commits intomasterfrom
fix/send-nano-tx

Conversation

@andreabadesso
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso commented Jul 31, 2025

Motivation

When creating a nano contract transaction, we might not have any inputs, as is the case in the initialize nano contract method.

Acceptance Criteria

  • We shouldn't crash when a transaction has no inputs in txProposalCreate

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Jul 31, 2025
@andreabadesso andreabadesso changed the base branch from master to refactor/zero-tx-weight July 31, 2025 19:35
@andreabadesso andreabadesso added the enhancement New feature or request label Aug 4, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (WIP) in Hathor Network Aug 4, 2025
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Aug 4, 2025
pedroferreira1
pedroferreira1 previously approved these changes Aug 5, 2025
@github-project-automation github-project-automation Bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 5, 2025
tuliomir
tuliomir previously approved these changes Aug 5, 2025
@tuliomir tuliomir moved this from In Review (WIP) to In Review (Done) in Hathor Network Aug 5, 2025
Base automatically changed from refactor/zero-tx-weight to master August 5, 2025 17:57
@andreabadesso andreabadesso dismissed stale reviews from tuliomir and pedroferreira1 August 5, 2025 17:57

The base branch was changed.

Signed-off-by: André Abadesso <andre.abadesso@gmail.com>
@github-project-automation github-project-automation Bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Aug 5, 2025
@andreabadesso andreabadesso merged commit 4bbba25 into master Aug 5, 2025
1 check passed
@andreabadesso andreabadesso deleted the fix/send-nano-tx branch August 5, 2025 18:19
@github-project-automation github-project-automation Bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Aug 5, 2025
This was referenced Nov 17, 2025
@andreabadesso andreabadesso moved this from Waiting to be deployed to Done in Hathor Network Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants