feat: error handler middleware

packages/wallet-service/src/api/addresses.ts

@@ -21,6 +21,7 @@ import { closeDbConnection, getDbConnection } from '@src/utils';
 import { walletIdProxyHandler } from '@src/commons';
 import middy from '@middy/core';
 import cors from '@middy/http-cors';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -104,7 +105,8 @@ export const checkMine: APIGatewayProxyHandler = middy(walletIdProxyHandler(asyn
       addresses: addressBelongMap,
     }),
   };
-})).use(cors());
+})).use(cors())
+  .use(errorHandler());
 
 /*
  * Get the addresses of a wallet, allowing an index filter
@@ -169,4 +171,5 @@ export const get: APIGatewayProxyHandler = middy(
     return response;
   }),
 ).use(cors())
-  .use(warmupMiddleware());
+  .use(warmupMiddleware())
+  .use(errorHandler());

packages/wallet-service/src/api/auth.ts

@@ -31,6 +31,7 @@ import cors from '@middy/http-cors';
 import createDefaultLogger from '@src/logger';
 import { Logger } from 'winston';
 import config from '@src/config';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const EXPIRATION_TIME_IN_SECONDS = 1800;
 
@@ -153,7 +154,8 @@ export const tokenHandler: APIGatewayProxyHandler = middy(async (event) => {
     statusCode: 200,
     body: JSON.stringify({ success: true, token }),
   };
-}).use(cors());
+}).use(cors())
+  .use(errorHandler());
 
 /**
  * Generates a aws policy document to allow/deny access to the resource
@@ -233,4 +235,5 @@ export const bearerAuthorizer: APIGatewayTokenAuthorizerHandler = middy(async (e
   }
 
   return _generatePolicy(walletId, 'Deny', event.methodArn, logger);
-}).use(cors());
+}).use(cors())
+  .use(errorHandler());

packages/wallet-service/src/api/balances.ts

@@ -22,6 +22,7 @@ import {
 import middy from '@middy/core';
 import cors from '@middy/http-cors';
 import Joi from 'joi';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -81,4 +82,5 @@ export const get: APIGatewayProxyHandler = middy(walletIdProxyHandler(async (wal
     body: JSON.stringify({ success: true, balances }),
   };
 })).use(cors())
-  .use(warmupMiddleware());
+  .use(warmupMiddleware())
+  .use(errorHandler());

packages/wallet-service/src/api/errors.ts

@@ -11,6 +11,7 @@ export enum ApiError {
   INVALID_TX_WEIGHT = 'invalid-tx-weight',
   INVALID_SELECTION_ALGORITHM = 'invalid-selection-algorithm',
   UNKNOWN_ERROR = 'unknown-error',
+  INTERNAL_SERVER_ERROR = 'internal-server-error',
   INPUTS_NOT_FOUND = 'inputs-not-found',
   INPUTS_ALREADY_USED = 'inputs-already-used',
   INPUTS_NOT_IN_WALLET = 'inputs-not-in-wallet',

packages/wallet-service/src/api/fullnodeProxy.ts

@@ -26,6 +26,7 @@ import {
   GetTxByIdParams,
   ParamValidationResult,
 } from '@src/types';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -70,7 +71,8 @@ export const getTransactionById: APIGatewayProxyHandler = middy(walletIdProxyHan
     statusCode: 200,
     body: JSON.stringify(transaction),
   };
-})).use(cors());
+})).use(cors())
+  .use(errorHandler());
 
 /*
  * Get confirmation data for a tx from the fullnode
@@ -96,7 +98,8 @@ export const getConfirmationData: APIGatewayProxyHandler = middy(walletIdProxyHa
     statusCode: 200,
     body: JSON.stringify(confirmationData),
   };
-})).use(cors());
+})).use(cors())
+  .use(errorHandler());
 
 /*
  * Makes graphviz queries on the fullnode
@@ -134,4 +137,5 @@ export const queryGraphvizNeighbours: APIGatewayProxyHandler = middy(
       body: JSON.stringify(graphVizData),
     };
   }),
-).use(cors());
+).use(cors())
+  .use(errorHandler());

packages/wallet-service/src/api/healthcheck.ts

@@ -13,6 +13,7 @@ import { closeDbConnection, getDbConnection } from '@src/utils';
 import { APIGatewayProxyHandler } from 'aws-lambda';
 import { getRedisClient, ping } from '@src/redis';
 import config from '@src/config';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -141,4 +142,4 @@ export const getHealthcheck: APIGatewayProxyHandler = middy(async (event) => {
     statusCode: response.getHttpStatusCode(),
     body: response.toJson(),
   };
-});
+}).use(errorHandler());

packages/wallet-service/src/api/middlewares/errorHandler.ts

@@ -0,0 +1,40 @@
+/**
+ * Copyright (c) Hathor Labs and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import middy from '@middy/core'
+import { APIGatewayProxyEvent, APIGatewayProxyResult } from 'aws-lambda'
+import createDefaultLogger from "@src/logger"
+import { STATUS_CODE_TABLE } from '@src/api/utils';
+import { ApiError } from '@src/api/errors';
+
+const logger = createDefaultLogger();
+
+const defaultResponse: APIGatewayProxyResult = { statusCode: STATUS_CODE_TABLE[ApiError.INTERNAL_SERVER_ERROR], body: ApiError.INTERNAL_SERVER_ERROR };
+
+const errorHandler = (): middy.MiddlewareObj<APIGatewayProxyEvent, APIGatewayProxyResult> => {
+   const onError: middy.MiddlewareFn<APIGatewayProxyEvent, APIGatewayProxyResult> = async (request)  => {
+    logger.error(`[${request.context?.functionName}] Unhandled error on ${request.event?.path}: ${request.error}`);
+
+    // Initialize response with default values if it hasn't been done yet.
+    request.response = request.response ?? {...defaultResponse};
+    // Force the status code to 500 since this is an unhandled error
+    request.response.statusCode = STATUS_CODE_TABLE[ApiError.INTERNAL_SERVER_ERROR];
+
+    // In production, we do not want to expose the error message to the user.
+    if (process.env.NODE_ENV === 'production') {
+      request.response.body = ApiError.INTERNAL_SERVER_ERROR;
+      return request.response;
+    }
+
+    request.response.body = request.error?.message || String(request.error);
+    return request.response;
+  }
+
+  return { onError };
+}
+
+export default errorHandler;

packages/wallet-service/src/api/miners.ts

@@ -15,6 +15,7 @@ import { closeDbConnection, getDbConnection } from '@src/utils';
 import { Miner } from '@src/types';
 import middy from '@middy/core';
 import cors from '@middy/http-cors';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -37,4 +38,5 @@ export const onMinersListRequest: APIGatewayProxyHandler = middy(async () => {
       miners: minersList,
     }),
   };
-}).use(cors());
+}).use(cors())
+  .use(errorHandler());

packages/wallet-service/src/api/newAddresses.ts

@@ -19,6 +19,7 @@ import { closeDbConnection, getDbConnection } from '@src/utils';
 import { walletIdProxyHandler } from '@src/commons';
 import middy from '@middy/core';
 import cors from '@middy/http-cors';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -47,4 +48,5 @@ export const get: APIGatewayProxyHandler = middy(walletIdProxyHandler(async (wal
     body: JSON.stringify({ success: true, addresses }),
   };
 })).use(cors())
-  .use(warmupMiddleware());
+  .use(warmupMiddleware())
+  .use(errorHandler());

packages/wallet-service/src/api/pushRegister.ts

@@ -15,6 +15,7 @@ import middy from '@middy/core';
 import cors from '@middy/http-cors';
 import Joi, { ValidationError } from 'joi';
 import { PushRegister } from '@src/types';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -80,4 +81,5 @@ export const register: APIGatewayProxyHandler = middy(walletIdProxyHandler(async
   };
 }))
   .use(cors())
-  .use(warmupMiddleware());
+  .use(warmupMiddleware())
+  .use(errorHandler());

packages/wallet-service/src/api/pushUnregister.ts

@@ -15,6 +15,7 @@ import middy from '@middy/core';
 import cors from '@middy/http-cors';
 import Joi, { ValidationError } from 'joi';
 import { PushDelete } from '@src/types';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -55,4 +56,5 @@ export const unregister: APIGatewayProxyHandler = middy(walletIdProxyHandler(asy
     body: JSON.stringify({ success: true }),
   };
 }))
-  .use(cors());
+  .use(cors())
+  .use(errorHandler());

packages/wallet-service/src/api/pushUpdate.ts

@@ -15,6 +15,7 @@ import middy from '@middy/core';
 import cors from '@middy/http-cors';
 import Joi, { ValidationError } from 'joi';
 import { PushUpdate } from '@src/types';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -75,4 +76,5 @@ export const update: APIGatewayProxyHandler = middy(walletIdProxyHandler(async (
     body: JSON.stringify({ success: true }),
   };
 }))
-  .use(cors());
+  .use(cors())
+  .use(errorHandler());

packages/wallet-service/src/api/tokens.ts

@@ -18,6 +18,7 @@ import Joi from 'joi';
 import { constants } from '@hathor/wallet-lib';
 import middy from '@middy/core';
 import cors from '@middy/http-cors';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -37,7 +38,8 @@ export const get = middy(walletIdProxyHandler(async (walletId) => {
     }),
   };
 })).use(cors())
-  .use(warmupMiddleware());
+  .use(warmupMiddleware())
+  .use(errorHandler());
 
 const getTokenDetailsParamsSchema = Joi.object({
   token_id: txIdJoiValidator.required(),
@@ -112,4 +114,5 @@ export const getTokenDetails = middy(walletIdProxyHandler(async (walletId, event
     }),
   };
 })).use(cors())
-  .use(warmupMiddleware());
+  .use(warmupMiddleware())
+  .use(errorHandler());

packages/wallet-service/src/api/totalSupply.ts

@@ -18,6 +18,7 @@ import middy from '@middy/core';
 import cors from '@middy/http-cors';
 import hathorLib from '@hathor/wallet-lib';
 import Joi from 'joi';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const htrToken = hathorLib.constants.NATIVE_TOKEN_UID;
 const mysql = getDbConnection();
@@ -61,4 +62,5 @@ export const onTotalSupplyRequest: APIGatewayProxyHandler = middy(async (event)
       totalSupply,
     }),
   };
-}).use(cors());
+}).use(cors())
+  .use(errorHandler());

packages/wallet-service/src/api/txById.ts

@@ -15,6 +15,7 @@ import middy from '@middy/core';
 import cors from '@middy/http-cors';
 import Joi, { ValidationError } from 'joi';
 import { TxByIdRequest } from '@src/types';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -59,4 +60,5 @@ export const get: APIGatewayProxyHandler = middy(walletIdProxyHandler(async (wal
   };
 }))
   .use(cors())
-  .use(warmupMiddleware());
+  .use(warmupMiddleware())
+  .use(errorHandler());

packages/wallet-service/src/api/txOutputs.ts

@@ -19,6 +19,7 @@ import { getDbConnection } from '@src/utils';
 import { constants } from '@hathor/wallet-lib';
 import middy from '@middy/core';
 import cors from '@middy/http-cors';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -92,7 +93,8 @@ export const getFilteredUtxos = middy(walletIdProxyHandler(async (walletId, even
   }
 
   return response;
-})).use(cors());
+})).use(cors())
+  .use(errorHandler());
 
 /*
  * Filter tx_outputs
@@ -131,7 +133,8 @@ export const getFilteredTxOutputs = middy(walletIdProxyHandler(async (walletId,
   }
 
   return _getFilteredTxOutputs(walletId, value);
-})).use(cors());
+})).use(cors())
+  .use(errorHandler());
 
 const _getFilteredTxOutputs = async (walletId: string, filters: IFilterTxOutput) => {
   const walletAddresses = await getWalletAddresses(mysql, walletId);

packages/wallet-service/src/api/txProposalCreate.ts

@@ -31,6 +31,7 @@ import cors from '@middy/http-cors';
 import { constants, Network, Transaction, helpersUtils } from '@hathor/wallet-lib';
 import { getFullnodeData } from '@src/nodeConfig';
 import config from '@src/config';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -143,7 +144,8 @@ export const create = middy(walletIdProxyHandler(async (walletId, event) => {
       inputs: retInputs,
     }),
   };
-})).use(cors());
+})).use(cors())
+  .use(errorHandler());
 
 /**
  * Confirm that all inputs requested by the user have been fetched.

packages/wallet-service/src/api/txProposalDestroy.ts

@@ -14,6 +14,7 @@ import { closeDbConnection, getDbConnection, getUnixTimestamp } from '@src/utils
 import { closeDbAndGetError } from '@src/api/utils';
 import middy from '@middy/core';
 import cors from '@middy/http-cors';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -67,4 +68,5 @@ export const destroy: APIGatewayProxyHandler = middy(walletIdProxyHandler(async
       txProposalId,
     }),
   };
-})).use(cors());
+})).use(cors())
+  .use(errorHandler());

packages/wallet-service/src/api/txProposalSend.ts

@@ -29,6 +29,7 @@ import { closeDbAndGetError } from '@src/api/utils';
 import middy from '@middy/core';
 import cors from '@middy/http-cors';
 import config from '@src/config';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const mysql = getDbConnection();
 
@@ -145,4 +146,5 @@ export const send: APIGatewayProxyHandler = middy(walletIdProxyHandler(async (wa
       txHex,
     });
   }
-})).use(cors());
+})).use(cors())
+  .use(errorHandler());

packages/wallet-service/src/api/txhistory.ts

@@ -20,6 +20,7 @@ import middy from '@middy/core';
 import cors from '@middy/http-cors';
 import Joi from 'joi';
 import config from '@src/config';
+import errorHandler from '@src/api/middlewares/errorHandler';
 
 const MAX_COUNT = config.txHistoryMaxCount;
 const htrToken = hathorLib.constants.NATIVE_TOKEN_UID;
@@ -87,4 +88,5 @@ export const get = middy(walletIdProxyHandler(async (walletId, event) => {
     body: JSON.stringify({ success: true, history, skip, count }),
   };
 })).use(cors())
-  .use(warmupMiddleware());
+  .use(warmupMiddleware())
+  .use(errorHandler());

packages/wallet-service/src/api/utils.ts

@@ -28,6 +28,7 @@ export const STATUS_CODE_TABLE = {
   [ApiError.INVALID_TX_WEIGHT]: 400,
   [ApiError.INVALID_SELECTION_ALGORITHM]: 400,
   [ApiError.UNKNOWN_ERROR]: 500,
+  [ApiError.INTERNAL_SERVER_ERROR]: 500,
   [ApiError.INPUTS_NOT_FOUND]: 400,
   [ApiError.INPUTS_ALREADY_USED]: 400,
   [ApiError.INSUFFICIENT_FUNDS]: 400,