Skip to content

fix: invalid parameter being sent to sendMessageSQS#209

Merged
andreabadesso merged 4 commits into
masterfrom
fix/realtime-txs
Jan 24, 2025
Merged

fix: invalid parameter being sent to sendMessageSQS#209
andreabadesso merged 4 commits into
masterfrom
fix/realtime-txs

Conversation

@andreabadesso
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso commented Jan 24, 2025 •
edited
Loading

Motivation

We changed the format of the object being sent to the real-time transaction SQS queue by mistake in #199, causing validation to fail on every new transaction sent to the queue.

Acceptance Criteria

  • We should fix the message format
  • We should include a helper method to send realtime transactions so we have types for the parameters

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Jan 24, 2025
@andreabadesso andreabadesso added the bug Something isn't working label Jan 24, 2025
tuliomir
tuliomir previously approved these changes Jan 24, 2025
View reviewed changes
pedroferreira1
pedroferreira1 previously approved these changes Jan 24, 2025
View reviewed changes
Comment thread packages/daemon/src/services/index.ts
@andreabadesso andreabadesso dismissed stale reviews from pedroferreira1 and tuliomir via 2b9fd51 January 24, 2025 16:32
@andreabadesso andreabadesso merged commit f15d8e1 into master Jan 24, 2025
@andreabadesso andreabadesso mentioned this pull request Jan 24, 2025
Merged
2 tasks
andreabadesso added a commit that referenced this pull request Jan 24, 2025
@andreabadesso
Release Candidate v1.6.4 (#206)
85c935e 
* refactor: increase network size to 32 characters in the database (#204)

* chore: bumped to v1.6.4 (#205)

* fix: invalid parameter being sent to sendMessageSQS (#209)

* fix: invalid parameter being sent to sendMessageSQS

* refactor: added helper method to send realtime tx

* docs: added docstring to sendRealtimeTx

* refactor: removed unused import
@andreabadesso andreabadesso mentioned this pull request Jan 24, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuliomir tuliomir tuliomir approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@andreabadesso andreabadesso

Labels

bug Something isn't working

Projects

Hathor Network
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreabadesso @tuliomir @pedroferreira1