Skip to content

feat: handling REORG_STARTED event plus tests#208

Merged
andreabadesso merged 7 commits into
masterfrom
feat/reorg-alert
Jan 30, 2025
Merged

feat: handling REORG_STARTED event plus tests#208
andreabadesso merged 7 commits into
masterfrom
feat/reorg-alert

Conversation

@andreabadesso
Copy link
Copy Markdown
Collaborator

@andreabadesso andreabadesso commented Jan 23, 2025 •
edited
Loading

Motivation

During the wallet-service refactor, we lost the reorg size alert, this PR should add it back

Acceptance Criteria

  • We should have different alert severities depending on the reorg size
  • We should include tests for all alarm sizes

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Jan 23, 2025
@andreabadesso andreabadesso added the enhancement New feature or request label Jan 23, 2025
@andreabadesso andreabadesso changed the title feat: handling METADATA_CHANGED event plus tests feat: handling REORG_STARTED event plus tests Jan 23, 2025
luislhl
luislhl reviewed Jan 27, 2025
View reviewed changes
Comment thread packages/daemon/src/config.ts Outdated
Comment on lines +92 to +93
export const REORG_SIZE_MAJOR = parseInt(process.env.REORG_SIZE_MAJOR ?? '10', 10);
export const REORG_SIZE_CRITICAL = parseInt(process.env.REORG_SIZE_CRITICAL ?? '10', 10);
Copy link
Copy Markdown
Collaborator

@luislhl luislhl Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Major and Critical will have the same size by default?

Copy link
Copy Markdown
Collaborator Author

@andreabadesso andreabadesso Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored MAJOR reorg default to 5, thanks!

luislhl
luislhl previously approved these changes Jan 27, 2025
View reviewed changes
glevco
glevco previously approved these changes Jan 27, 2025
View reviewed changes
@andreabadesso andreabadesso dismissed stale reviews from glevco and luislhl via d5a36d0 January 30, 2025 13:16
@andreabadesso andreabadesso merged commit 273690f into master Jan 30, 2025
@andreabadesso andreabadesso deleted the feat/reorg-alert branch January 30, 2025 15:19
This was referenced Jan 30, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glevco glevco glevco approved these changes

@luislhl luislhl luislhl approved these changes

Assignees

@andreabadesso andreabadesso

Labels

enhancement New feature or request

Projects

Hathor Network
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreabadesso @glevco @luislhl