Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (44.77%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #986 +/- ##
===========================================
- Coverage 87.32% 67.40% -19.93%
===========================================
Files 114 114
Lines 8640 8660 +20
Branches 1924 1935 +11
===========================================
- Hits 7545 5837 -1708
- Misses 1067 2796 +1729
+ Partials 28 27 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # src/api/schemas/txApi.ts # src/api/txApi.ts # src/new/types.ts # src/new/wallet.ts
# Conflicts: # src/new/types.ts # src/new/wallet.ts
Resolves conflicts from fee-based tokens: - src/new/wallet.ts: Preserve type safety improvements, integrate imports - src/nano_contracts/builder.ts: Adopt AuthorityType enum - walletservice_facade tests: Keep directory structure, integrate fee tests Additional changes: - Fix poolForTx -> pollForTx naming inconsistency - Consolidate duplicate pollForTx function - Clean up duplicate imports Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Important
This PR is not supposed to be merged directly to
master.This PR and branch are used to help development of the shared tests for the Fullnode and Wallet Service facades. Instead, it will be split among many PRs for review process, which would otherwise be unfeasible.
It depends on #982 and builds upon concepts from the PoC on #947
List of PRs that implement this task:
start#1032