Skip to content

Test: Shared facades#986

Draft
tuliomir wants to merge 79 commits intomasterfrom
test/shared-facades
Draft

Test: Shared facades#986
tuliomir wants to merge 79 commits intomasterfrom
test/shared-facades

Conversation

@tuliomir
Copy link
Copy Markdown
Contributor

@tuliomir tuliomir commented Dec 30, 2025

Important

This PR is not supposed to be merged directly to master.

This PR and branch are used to help development of the shared tests for the Fullnode and Wallet Service facades. Instead, it will be split among many PRs for review process, which would otherwise be unfeasible.

It depends on #982 and builds upon concepts from the PoC on #947

List of PRs that implement this task:

@tuliomir tuliomir self-assigned this Dec 30, 2025
@tuliomir tuliomir moved this from Todo to In Progress (WIP) in Hathor Network Dec 30, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 44.77612% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.40%. Comparing base (bb46775) to head (c750800).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
src/new/wallet.ts 41.12% 73 Missing ⚠️
src/new/sendTransaction.ts 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (44.77%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (67.40%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (bb46775) and HEAD (c750800). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (bb46775) HEAD (c750800)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #986       +/-   ##
===========================================
- Coverage   87.32%   67.40%   -19.93%     
===========================================
  Files         114      114               
  Lines        8640     8660       +20     
  Branches     1924     1935       +11     
===========================================
- Hits         7545     5837     -1708     
- Misses       1067     2796     +1729     
+ Partials       28       27        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tuliomir tuliomir added the tests label Jan 2, 2026
tuliomir and others added 7 commits January 15, 2026 21:14
# Conflicts:
#	src/api/schemas/txApi.ts
#	src/api/txApi.ts
#	src/new/types.ts
#	src/new/wallet.ts
# Conflicts:
#	src/new/types.ts
#	src/new/wallet.ts
Resolves conflicts from fee-based tokens:
- src/new/wallet.ts: Preserve type safety improvements, integrate imports
- src/nano_contracts/builder.ts: Adopt AuthorityType enum
- walletservice_facade tests: Keep directory structure, integrate fee tests

Additional changes:
- Fix poolForTx -> pollForTx naming inconsistency
- Consolidate duplicate pollForTx function
- Clean up duplicate imports

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In Progress (WIP)

Development

Successfully merging this pull request may close these issues.

1 participant