tests: use yml as configuration file for hathor core#588
Merged
pedroferreira1 merged 1 commit intodevfrom Nov 8, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #588 +/- ##
=======================================
Coverage 64.86% 64.86%
=======================================
Files 67 67
Lines 5254 5254
Branches 1108 1108
=======================================
Hits 3408 3408
Misses 1766 1766
Partials 80 80 ☔ View full report in Codecov by Sentry. |
tuliomir
approved these changes
Nov 7, 2023
andreabadesso
approved these changes
Nov 8, 2023
Contributor
andreabadesso
left a comment
There was a problem hiding this comment.
Integration tests are failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
hathor-corewill remove support for using custom python configuration file, so we must change in the integration tests to use a yml file.Security Checklist