Skip to content

tests: use yml as configuration file for hathor core#588

Merged
pedroferreira1 merged 1 commit intodevfrom
tests/hathor-core-integration-tests-yml
Nov 8, 2023
Merged

tests: use yml as configuration file for hathor core#588
pedroferreira1 merged 1 commit intodevfrom
tests/hathor-core-integration-tests-yml

Conversation

@pedroferreira1
Copy link
Copy Markdown
Member

Acceptance Criteria

  • Soon hathor-core will remove support for using custom python configuration file, so we must change in the integration tests to use a yml file.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (217797f) 64.86% compared to head (c5edcc3) 64.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #588   +/-   ##
=======================================
  Coverage   64.86%   64.86%           
=======================================
  Files          67       67           
  Lines        5254     5254           
  Branches     1108     1108           
=======================================
  Hits         3408     3408           
  Misses       1766     1766           
  Partials       80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@andreabadesso andreabadesso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests are failing

@pedroferreira1 pedroferreira1 merged commit ff84c40 into dev Nov 8, 2023
@alexruzenhack alexruzenhack mentioned this pull request Nov 9, 2023
1 task
@r4mmer r4mmer deleted the tests/hathor-core-integration-tests-yml branch March 21, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants