feat: compile entrypoint file with typescript#577
Merged
Conversation
r4mmer
force-pushed
the
feat/lib-typing-declaration
branch
from
549802e to
7625343
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #577 +/- ##
=======================================
Coverage 78.28% 78.28%
=======================================
Files 67 67
Lines 5254 5254
Branches 1108 1108
=======================================
Hits 4113 4113
Misses 1126 1126
Partials 15 15 ☔ View full report in Codecov by Sentry. |
r4mmer
commented
Sep 25, 2023
src/index.ts
Outdated
| import dateFormatter from './utils/date'; | ||
| import websocket from './websocket'; | ||
| import * as errors from './errors'; | ||
| import * as ErrorMessages from './errorMessages'; |
Member
Author
There was a problem hiding this comment.
We could just import the ErrorMessages enum but the wallets use the hathorLib.ErrorMessages.ErrorMessages... so I'll keep this "unnecessary encapsulation" so we don't have to refactor the wallets
andreabadesso
approved these changes
Sep 28, 2023
pedroferreira1
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Security Checklist